mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

native: Use foreach to iterate trough modules.

Browse source 
The PA_IDXSET_FOREACH is easier to read than the standard for loop.
Also pa_streq() should be used for checking string equality.
This commit is contained in:
poljar 2012-05-21 21:42:20 +02:00 • committed by Tanu Kaskinen
parent 21b1d92b79
commit 4c65e58325
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/pulsecore/protocol-native.c
View file

@ -4623,11 +4623,10 @@ static void command_extension(pa_pdispatch *pd, uint32_t command, uint32_t tag,
if (idx != PA_INVALID_INDEX) if (idx != PA_INVALID_INDEX)
m = pa_idxset_get_by_index(c->protocol->core->modules, idx); m = pa_idxset_get_by_index(c->protocol->core->modules, idx);
else { else
for (m = pa_idxset_first(c->protocol->core->modules, &idx); m; m = pa_idxset_next(c->protocol->core->modules, &idx)) PA_IDXSET_FOREACH(m, c->protocol->core->modules, idx)
if (strcmp(name, m->name) == 0) if (pa_streq(name, m->name))
break; break;
}
CHECK_VALIDITY(c->pstream, m, tag, PA_ERR_NOEXTENSION); CHECK_VALIDITY(c->pstream, m, tag, PA_ERR_NOEXTENSION);
CHECK_VALIDITY(c->pstream, m->load_once || idx != PA_INVALID_INDEX, tag, PA_ERR_INVALID); CHECK_VALIDITY(c->pstream, m->load_once || idx != PA_INVALID_INDEX, tag, PA_ERR_INVALID);