mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluetooth: fix invalid memory access

Browse source 
When an GetProperties() reply arrives after we already deleted the
device structure for it make sure we don't accidentaly touch the
invalidated object.

https://bugzilla.redhat.com/show_bug.cgi?id=543205
This commit is contained in:
Lennart Poettering 2010-01-13 17:24:37 +01:00 • committed by Colin Guthrie
parent 7f7455b1be
commit 41ce7cbde9
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/modules/bluetooth/bluetooth-util.c
View file

@ -342,7 +342,13 @@ static void get_properties_reply(DBusPendingCall *pending, void *userdata) {
/* dbus_message_get_interface(p->message), */ /* dbus_message_get_interface(p->message), */
/* dbus_message_get_path(p->message)); */ /* dbus_message_get_path(p->message)); */
d = p->call_data; /* We don't use p->call_data here right-away since the device
* might already be invalidated at this point */
if (!(d = pa_hashmap_get(y->devices, dbus_message_get_path(p->message))))
return;
pa_assert(p->call_data == d);
valid = dbus_message_get_type(r) == DBUS_MESSAGE_TYPE_ERROR ? -1 : 1; valid = dbus_message_get_type(r) == DBUS_MESSAGE_TYPE_ERROR ? -1 : 1;