From 3f2a0c17baa976b7d2d4bafad7a8e703ffd0191a Mon Sep 17 00:00:00 2001 From: Tomaz Solc Date: Tue, 29 May 2018 09:22:59 +0200 Subject: [PATCH] cli-command: Report error in pa_play_file. Current code does not check whether pa_play_file call failed. Hence no error is reported in the cli interface if playback failed because e.g. file isn't readable by the daemon. --- src/pulsecore/cli-command.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pulsecore/cli-command.c b/src/pulsecore/cli-command.c index 44795b0d9..defdac1ec 100644 --- a/src/pulsecore/cli-command.c +++ b/src/pulsecore/cli-command.c @@ -1282,7 +1282,12 @@ static int pa_cli_command_play_file(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, return -1; } - return pa_play_file(sink, fname, NULL); + if (pa_play_file(sink, fname, NULL) < 0) { + pa_strbuf_puts(buf, "Failed to play sound file.\n"); + return -1; + } + + return 0; } static int pa_cli_command_list_shared_props(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, bool *fail) {