mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

equalizer: Don't cleanup u->sink in sink_input_kill_cb yet

Browse source 
Previously, sink_input_kill_cb would cleanup u->sink an then unload the
module. However, during module unload, both save_state and dbus_done
tried to use u->sink, causing a segfault or assertion failure.

The segfault is easy to reproduce: Load module-equalizer-sink and then
press ctrl-C to terminate pulseaudio.

This commit removes the u->sink cleanup in sink_input_kill_cb, since
u->sink will be cleaned up by the module's pa__done as well (after it
has been used).

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
This commit is contained in:
Matthijs Kooijman 2012-09-24 14:40:06 +02:00 • committed by Tanu Kaskinen
parent 626085ed9c
commit 3d2d30f688
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/modules/module-equalizer-sink.c
View file

@ -849,8 +849,8 @@ static void sink_input_kill_cb(pa_sink_input *i) {
pa_sink_input_unref(u->sink_input); pa_sink_input_unref(u->sink_input);
u->sink_input = NULL; u->sink_input = NULL;
pa_sink_unref(u->sink); /* Leave u->sink alone for now, it will be cleaned up on module
u->sink = NULL; * unload (and it is needed during unload as well). */
pa_module_unload_request(u->module, TRUE); pa_module_unload_request(u->module, TRUE);
} }