mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-06 13:29:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

s/assert/pa_assert/ modernizations

Browse source 
git-svn-id: file:///home/lennart/svn/public/pulseaudio/branches/lennart@1796 fefdeb5f-60dc-0310-8127-8f9354f1896f
This commit is contained in:
Lennart Poettering 2007-09-10 22:17:30 +00:00
parent de21b54bd1
commit 3d122d0fee
1 changed files with 31 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

50
src/pulse/mainloop-signal.c
View file

@ -27,7 +27,6 @@
#endif #endif
#include <stdio.h> #include <stdio.h>
#include <assert.h>
#include <signal.h> #include <signal.h>
#include <errno.h> #include <errno.h>
#include <stdlib.h> #include <stdlib.h>
@ -39,12 +38,13 @@
#include <windows.h> #include <windows.h>
#endif #endif
#include <pulsecore/core-error.h>
#include <pulse/xmalloc.h> #include <pulse/xmalloc.h>
#include <pulsecore/core-error.h>
#include <pulsecore/core-util.h> #include <pulsecore/core-util.h>
#include <pulsecore/log.h> #include <pulsecore/log.h>
#include <pulsecore/gccmacro.h> #include <pulsecore/gccmacro.h>
#include <pulsecore/macro.h>
#include "mainloop-signal.h" #include "mainloop-signal.h"
@ -74,11 +74,11 @@ static void signal_handler(int sig) {
} }
static void dispatch(pa_mainloop_api*a, int sig) { static void dispatch(pa_mainloop_api*a, int sig) {
pa_signal_event*s; pa_signal_event *s;
for (s = signals; s; s = s->next) for (s = signals; s; s = s->next)
if (s->sig == sig) { if (s->sig == sig) {
assert(s->callback); pa_assert(s->callback);
s->callback(a, s, sig, s->userdata); s->callback(a, s, sig, s->userdata);
break; break;
} }
@ -87,7 +87,12 @@ static void dispatch(pa_mainloop_api*a, int sig) {
static void callback(pa_mainloop_api*a, pa_io_event*e, int fd, pa_io_event_flags_t f, PA_GCC_UNUSED void *userdata) { static void callback(pa_mainloop_api*a, pa_io_event*e, int fd, pa_io_event_flags_t f, PA_GCC_UNUSED void *userdata) {
ssize_t r; ssize_t r;
int sig; int sig;
assert(a && e && f == PA_IO_EVENT_INPUT && e == io_event && fd == signal_pipe[0]);
pa_assert(a);
pa_assert(e);
pa_assert(f == PA_IO_EVENT_INPUT);
pa_assert(e == io_event);
pa_assert(fd == signal_pipe[0]);
if ((r = pa_read(signal_pipe[0], &sig, sizeof(sig), NULL)) < 0) { if ((r = pa_read(signal_pipe[0], &sig, sizeof(sig), NULL)) < 0) {
if (errno == EAGAIN) if (errno == EAGAIN)
@ -107,7 +112,11 @@ static void callback(pa_mainloop_api*a, pa_io_event*e, int fd, pa_io_event_flags
int pa_signal_init(pa_mainloop_api *a) { int pa_signal_init(pa_mainloop_api *a) {
assert(!api && a && signal_pipe[0] == -1 && signal_pipe[1] == -1 && !io_event); pa_assert(a);
pa_assert(!api);
pa_assert(signal_pipe[0] == -1);
pa_assert(signal_pipe[1] == -1);
pa_assert(!io_event);
if (pipe(signal_pipe) < 0) { if (pipe(signal_pipe) < 0) {
pa_log("pipe(): %s", pa_cstrerror(errno)); pa_log("pipe(): %s", pa_cstrerror(errno));
@ -116,19 +125,21 @@ int pa_signal_init(pa_mainloop_api *a) {
pa_make_nonblock_fd(signal_pipe[0]); pa_make_nonblock_fd(signal_pipe[0]);
pa_make_nonblock_fd(signal_pipe[1]); pa_make_nonblock_fd(signal_pipe[1]);
pa_fd_set_cloexec(signal_pipe[0], 1); pa_assert_se(pa_fd_set_cloexec(signal_pipe[0], 1) == 0);
pa_fd_set_cloexec(signal_pipe[1], 1); pa_assert_se(pa_fd_set_cloexec(signal_pipe[1], 1) == 0);
api = a; api = a;
io_event = api->io_new(api, signal_pipe[0], PA_IO_EVENT_INPUT, callback, NULL); pa_assert_se(io_event = api->io_new(api, signal_pipe[0], PA_IO_EVENT_INPUT, callback, NULL));
assert(io_event);
return 0; return 0;
} }
void pa_signal_done(void) { void pa_signal_done(void) {
assert(api && signal_pipe[0] >= 0 && signal_pipe[1] >= 0 && io_event); pa_assert(api);
pa_assert(signal_pipe[0] >= 0);
pa_assert(signal_pipe[1] >= 0);
pa_assert(io_event);
while (signals) while (signals)
pa_signal_free(signals); pa_signal_free(signals);
@ -136,8 +147,8 @@ void pa_signal_done(void) {
api->io_free(io_event); api->io_free(io_event);
io_event = NULL; io_event = NULL;
close(signal_pipe[0]); pa_assert_se(close(signal_pipe[0]) == 0);
close(signal_pipe[1]); pa_assert_se(close(signal_pipe[1]) == 0);
signal_pipe[0] = signal_pipe[1] = -1; signal_pipe[0] = signal_pipe[1] = -1;
api = NULL; api = NULL;
@ -150,13 +161,13 @@ pa_signal_event* pa_signal_new(int sig, void (*_callback) (pa_mainloop_api *api,
struct sigaction sa; struct sigaction sa;
#endif #endif
assert(sig > 0 && _callback); pa_assert(sig > 0 && _callback);
for (e = signals; e; e = e->next) for (e = signals; e; e = e->next)
if (e->sig == sig) if (e->sig == sig)
goto fail; goto fail;
e = pa_xmalloc(sizeof(pa_signal_event)); e = pa_xnew(pa_signal_event, 1);
e->sig = sig; e->sig = sig;
e->callback = _callback; e->callback = _callback;
e->userdata = userdata; e->userdata = userdata;
@ -186,7 +197,7 @@ fail:
} }
void pa_signal_free(pa_signal_event *e) { void pa_signal_free(pa_signal_event *e) {
assert(e); pa_assert(e);
if (e->next) if (e->next)
e->next->previous = e->previous; e->next->previous = e->previous;
@ -196,9 +207,9 @@ void pa_signal_free(pa_signal_event *e) {
signals = e->next; signals = e->next;
#ifdef HAVE_SIGACTION #ifdef HAVE_SIGACTION
sigaction(e->sig, &e->saved_sigaction, NULL); pa_assert_se(sigaction(e->sig, &e->saved_sigaction, NULL) == 0);
#else #else
signal(e->sig, e->saved_handler); pa_assert_se(signal(e->sig, e->saved_handler) == signal_handler);
#endif #endif
if (e->destroy_callback) if (e->destroy_callback)
@ -208,6 +219,7 @@ void pa_signal_free(pa_signal_event *e) {
} }
void pa_signal_set_destroy(pa_signal_event *e, void (*_callback) (pa_mainloop_api *api, pa_signal_event*e, void *userdata)) { void pa_signal_set_destroy(pa_signal_event *e, void (*_callback) (pa_mainloop_api *api, pa_signal_event*e, void *userdata)) {
assert(e); pa_assert(e);
e->destroy_callback = _callback; e->destroy_callback = _callback;
} }