mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Get rid of some warnings: -Wunused-result

Browse source 
modules/module-default-device-restore.c: In function ‘load’:
modules/module-default-device-restore.c:67: warning: ignoring return value of ‘fgets’,
declared with attribute warn_unused_result [-Wunused-result]
modules/module-default-device-restore.c:88: warning: ignoring return value of ‘fgets’,
declared with attribute warn_unused_result [-Wunused-result]

pulsecore/authkey.c: In function ‘generate’:
pulsecore/authkey.c:58: warning: ignoring return value of ‘ftruncate’,
declared with attribute warn_unused_result [-Wunused-result]

pulsecore/core-util.c: In function ‘pa_make_secure_dir’:
pulsecore/core-util.c:261: warning: ignoring return value of ‘fchown’,
declared with attribute warn_unused_result [-Wunused-result]
This commit is contained in:
Maarten Bosmans 2011-03-19 13:59:15 +01:00 • committed by Colin Guthrie
parent d7ce59de88
commit 33a88fbfde
3 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/modules/module-default-device-restore.c
View file

@ -64,8 +64,8 @@ static void load(struct userdata *u) {
char ln[256] = "";
pa_sink *s;
(void) fgets(ln, sizeof(ln)-1, f);
pa_strip_nl(ln);
if (fgets(ln, sizeof(ln)-1, f))
pa_strip_nl(ln);
fclose(f);
if (!ln[0])
@ -85,8 +85,8 @@ static void load(struct userdata *u) {
char ln[256] = "";
pa_source *s;
(void) fgets(ln, sizeof(ln)-1, f);
pa_strip_nl(ln);
if (fgets(ln, sizeof(ln)-1, f))
pa_strip_nl(ln);
fclose(f);
if (!ln[0])

5
src/pulsecore/authkey.c
View file

@ -55,7 +55,10 @@ static int generate(int fd, void *ret_data, size_t length) {
pa_random(ret_data, length);
lseek(fd, (off_t) 0, SEEK_SET);
(void) ftruncate(fd, (off_t) 0);
if (ftruncate(fd, (off_t) 0) < 0) {
pa_log("Failed to truncate cookie file: %s", pa_cstrerror(errno));
return -1;
}
if ((r = pa_loop_write(fd, ret_data, length, NULL)) < 0 || (size_t) r != length) {
pa_log("Failed to write cookie file: %s", pa_cstrerror(errno));

7
src/pulsecore/core-util.c
View file

@ -259,11 +259,12 @@ int pa_make_secure_dir(const char* dir, mode_t m, uid_t uid, gid_t gid) {
}
#ifdef HAVE_FCHOWN
if (uid == (uid_t)-1)
if (uid == (uid_t) -1)
uid = getuid();
if (gid == (gid_t)-1)
if (gid == (gid_t) -1)
gid = getgid();
(void) fchown(fd, uid, gid);
if (fchown(fd, uid, gid) < 0)
goto fail;
#endif
#ifdef HAVE_FCHMOD