mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: Allow off-by-one error in sconv test

Browse source 
With some optimised sconv implementations (read NEON), rounding
inaccuracy might lead to a difference of 1 with the reference
implementation. The inaccuracy is worth the performance gain.

Also increases floating-point accuracy while printing errors to make
errors easier to analyse.
This commit is contained in:
Arun Raghavan 2012-10-26 16:39:11 +05:30
parent 1a8ec3c3e0
commit 32b4e848ae
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/tests/cpu-test.c
View file

@ -231,8 +231,8 @@ static void run_conv_test_float_to_s16(pa_convert_func_t func, pa_convert_func_t
func(nsamples, floats, samples); func(nsamples, floats, samples);
for (i = 0; i < nsamples; i++) { for (i = 0; i < nsamples; i++) {
if (samples[i] != samples_ref[i]) { if (abs(samples[i] - samples_ref[i]) > 1) {
pa_log_debug("%d: %04x != %04x (%f)\n", i, samples[i], samples_ref[i], floats[i]); pa_log_debug("%d: %04x != %04x (%.24f)\n", i, samples[i], samples_ref[i], floats[i]);
fail(); fail();
} }
} }
@ -248,8 +248,6 @@ static void run_conv_test_float_to_s16(pa_convert_func_t func, pa_convert_func_t
PA_CPU_TEST_RUN_START("orig", TIMES, TIMES2) { PA_CPU_TEST_RUN_START("orig", TIMES, TIMES2) {
orig_func(nsamples, floats, samples_ref); orig_func(nsamples, floats, samples_ref);
} PA_CPU_TEST_RUN_STOP } PA_CPU_TEST_RUN_STOP
fail_unless(memcmp(samples_ref, samples, sizeof(nsamples)) == 0);
} }
} }
@ -277,8 +275,8 @@ static void run_conv_test_s16_to_float(pa_convert_func_t func, pa_convert_func_t
func(nsamples, samples, floats); func(nsamples, samples, floats);
for (i = 0; i < nsamples; i++) { for (i = 0; i < nsamples; i++) {
if (floats[i] != floats_ref[i]) { if (abs(floats[i] - floats_ref[i]) > 1) {
pa_log_debug("%d: %f != %f (%d)\n", i, floats[i], floats_ref[i], samples[i]); pa_log_debug("%d: %.24f != %.24f (%d)\n", i, floats[i], floats_ref[i], samples[i]);
fail(); fail();
} }
} }
@ -294,8 +292,6 @@ static void run_conv_test_s16_to_float(pa_convert_func_t func, pa_convert_func_t
PA_CPU_TEST_RUN_START("orig", TIMES, TIMES2) { PA_CPU_TEST_RUN_START("orig", TIMES, TIMES2) {
orig_func(nsamples, samples, floats_ref); orig_func(nsamples, samples, floats_ref);
} PA_CPU_TEST_RUN_STOP } PA_CPU_TEST_RUN_STOP
fail_unless(memcmp(floats_ref, floats, nsamples * sizeof(float)) == 0);
} }
} }