smoother: add comments about optimization recommendations from Jason Newton

This commit is contained in:
Lennart Poettering 2009-10-29 01:49:40 +01:00
parent f27a50691c
commit 2edb4df175

View file

@ -196,6 +196,13 @@ static double avg_gradient(pa_smoother *s, pa_usec_t x) {
int64_t ax = 0, ay = 0, k, t; int64_t ax = 0, ay = 0, k, t;
double r; double r;
/* FIXME: Optimization: Jason Newton suggested that instead of
* going through the history on each iteration we could calculated
* avg_gradient() as we go.
*
* Second idea: it might make sense to weight history entries:
* more recent entries should matter more than old ones. */
/* Too few measurements, assume gradient of 1 */ /* Too few measurements, assume gradient of 1 */
if (s->n_history < s->min_history) if (s->n_history < s->min_history)
return 1; return 1;