mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

alsa: add a couple of FIXME comments

Browse source 
build_pollfd() isn't likely to fail, but if it does, pa_sink/source_put()
will crash on an assertion failure. I haven't seen such crash happening,
this is just something that I noticed while studying the state change
code.
This commit is contained in:
Tanu Kaskinen 2018-02-19 16:48:21 +02:00
parent 7f201b1fd4
commit 2dff0d6a6a
2 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/modules/alsa/alsa-sink.c
View file

@ -1203,6 +1203,9 @@ static int sink_process_msg(pa_msgobject *o, int code, void *data, int64_t offse
if (u->sink->thread_info.state == PA_SINK_INIT) { if (u->sink->thread_info.state == PA_SINK_INIT) {
if (build_pollfd(u) < 0) if (build_pollfd(u) < 0)
/* FIXME: This will cause an assertion failure in
* pa_sink_put(), because with the current design
* pa_sink_put() is not allowed to fail. */
return -PA_ERR_IO; return -PA_ERR_IO;
} }

3
src/modules/alsa/alsa-source.c
View file

@ -1058,6 +1058,9 @@ static int source_process_msg(pa_msgobject *o, int code, void *data, int64_t off
if (u->source->thread_info.state == PA_SOURCE_INIT) { if (u->source->thread_info.state == PA_SOURCE_INIT) {
if (build_pollfd(u) < 0) if (build_pollfd(u) < 0)
/* FIXME: This will cause an assertion failure in
* pa_source_put(), because with the current design
* pa_source_put() is not allowed to fail. */
return -PA_ERR_IO; return -PA_ERR_IO;
} }