mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

echo-cancel: Try to minimise in-flight chunks in snapshot latency

Browse source 
We don't always know whether the in-flight memory chunks will be
rendered or skipped (if the source is not in RUNNING). This can cause us
to have an erroneous estimate of drift, particularly when the canceller
starts.

To avoid this, we explicitly flush out the send and receive sides of the
message queue of audio chunks going from the sink to the source before
trying to perform a resync.
This commit is contained in:
Arun Raghavan 2017-03-09 09:58:23 +05:30
parent f4f01f6833
commit 2c2ca1c949
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/modules/echo-cancel/module-echo-cancel.c
View file

@ -689,8 +689,13 @@ static void do_resync(struct userdata *u) {
pa_log("Doing resync"); pa_log("Doing resync");
/* update our snapshot */ /* update our snapshot */
source_output_snapshot_within_thread(u, &latency_snapshot); /* 1. Get sink input latency snapshot, might cause buffers to be sent to source thread */
pa_asyncmsgq_send(u->sink_input->sink->asyncmsgq, PA_MSGOBJECT(u->sink_input), SINK_INPUT_MESSAGE_LATENCY_SNAPSHOT, &latency_snapshot, 0, NULL); pa_asyncmsgq_send(u->sink_input->sink->asyncmsgq, PA_MSGOBJECT(u->sink_input), SINK_INPUT_MESSAGE_LATENCY_SNAPSHOT, &latency_snapshot, 0, NULL);
/* 2. Pick up any in-flight buffers (and discard if needed) */
while (pa_asyncmsgq_process_one(u->asyncmsgq))
;
/* 3. Now get the source output latency snapshot */
source_output_snapshot_within_thread(u, &latency_snapshot);
/* calculate drift between capture and playback */ /* calculate drift between capture and playback */
diff_time = calc_diff(u, &latency_snapshot); diff_time = calc_diff(u, &latency_snapshot);