mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-02 09:01:46 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: fix use of uninitialized variable cpu_info

Browse source 
On cpu-volume-test, cpu_info is initialized only on i386/amd64 systems,
and otherwise passed on to pa_cpu_init_orc() uninitialized.

If one was unlucky enough, they could end up with cpu_info.cpu_type ==
PA_CPU_X86 on a non-x86 system, and use and test the Orc codepath
without that being functional, and thus with the test failing.

This has been observed in the wild on the ppc64el Debian buildds. See
Debian bug #982740 for more context.

Define cpu_info here in the same way as in other tests.

Signed-off-by: Faidon Liambotis <paravoid@debian.org>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/511>
This commit is contained in:
Faidon Liambotis 2021-02-26 03:23:52 +02:00 • committed by PulseAudio Marge Bot
parent 8f59e3e275
commit 2afecd637c
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/tests/cpu-volume-test.c
View file

@ -187,7 +187,7 @@ END_TEST
START_TEST (svolume_orc_test) { START_TEST (svolume_orc_test) {
pa_do_volume_func_t orig_func, orc_func; pa_do_volume_func_t orig_func, orc_func;
pa_cpu_info cpu_info; pa_cpu_info cpu_info = { PA_CPU_UNDEFINED, {}, false };
int i, j; int i, j;
#if defined (__i386__) || defined (__amd64__) #if defined (__i386__) || defined (__amd64__)