mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

switch-on-connect: Fix warning on discarded const qualifier

Browse source 
pa_modargs_get_value() returns a const string -- instead of discarding
the const qualifier, let's just duplicate the string and free it
explicitly in the failure case.
This commit is contained in:
Arun Raghavan 2019-11-22 21:16:33 +05:30
parent ad16d77dfe
commit 26a66d103f
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/modules/module-switch-on-connect.c
View file

@ -249,12 +249,10 @@ int pa__init(pa_module*m) {
goto fail; goto fail;
} }
u->blacklist = pa_modargs_get_value(ma, "blacklist", NULL); u->blacklist = pa_xstrdup(pa_modargs_get_value(ma, "blacklist", NULL));
if (u->blacklist != NULL && pa_is_regex_valid(u->blacklist)) { if (u->blacklist != NULL && !pa_is_regex_valid(u->blacklist)) {
/* String returned above will be freed with modargs, duplicate it */ pa_log_error("A blacklist pattern was provided but is not a valid regex");
u->blacklist = pa_xstrdup(u->blacklist); pa_xfree(u->blacklist);
} else if (u->blacklist != NULL) {
pa_log_error("A blacklist pattern was provided but is not a valid regex.");
goto fail; goto fail;
} }