From 250fd43bdc9f45bda071f38bb2420ace31b48f81 Mon Sep 17 00:00:00 2001 From: Peter Meerwald-Stadler Date: Thu, 18 Aug 2016 09:24:41 +0200 Subject: [PATCH] tests: Assert granularity range in stripnul.c granularity must not be larger than buffer size CID 1138482 --- src/tests/stripnul.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tests/stripnul.c b/src/tests/stripnul.c index 75390bd57..e4b07aa83 100644 --- a/src/tests/stripnul.c +++ b/src/tests/stripnul.c @@ -26,6 +26,8 @@ #include #include +#define MAX_BUFFER (16*1024) + int main(int argc, char *argv[]) { FILE *i, *o; size_t granularity; @@ -34,13 +36,14 @@ int main(int argc, char *argv[]) { pa_assert_se(argc >= 2); pa_assert_se((granularity = (size_t) atoi(argv[1])) >= 1); + pa_assert(granularity <= MAX_BUFFER); pa_assert_se((i = (argc >= 3) ? fopen(argv[2], "r") : stdin)); pa_assert_se((o = (argc >= 4) ? fopen(argv[3], "w") : stdout)); zero = pa_xmalloc0(granularity); for (;;) { - uint8_t buffer[16*1024], *p; + uint8_t buffer[MAX_BUFFER], *p; size_t k; k = fread(buffer, granularity, sizeof(buffer)/granularity, i);