mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-08 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

dbus: Do not refcnt the core.

Browse source 
We should not call pa_core_ref() anywhere in the code. Doing so
will prevent proper daemon shutdown as the only call (in daemon/main.c)
to pa_core_unref() should always call free_core() and perform a normal
shutdown (i.e. unload all modules gracefully).
This commit is contained in:
Colin Guthrie 2011-03-25 23:43:26 +00:00
parent 7aa8a3fa80
commit 1e381fbffc
3 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/modules/dbus/iface-memstats.c
View file

@ -202,7 +202,7 @@ pa_dbusiface_memstats *pa_dbusiface_memstats_new(pa_dbusiface_core *dbus_core, p
pa_assert(core);
m = pa_xnew(pa_dbusiface_memstats, 1);
m->core = pa_core_ref(core);
m->core = core;
m->path = pa_sprintf_malloc("%s/%s", PA_DBUS_CORE_OBJECT_PATH, OBJECT_NAME);
m->dbus_protocol = pa_dbus_protocol_get(core);
@ -219,7 +219,6 @@ void pa_dbusiface_memstats_free(pa_dbusiface_memstats *m) {
pa_xfree(m->path);
pa_dbus_protocol_unref(m->dbus_protocol);
pa_core_unref(m->core);
pa_xfree(m);
}