mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

core-util: Use _SC_NPROCESSORS_ONLN instead of _SC_NPROCESSORS_CONF

Browse source 
pa_ncpu() is supposed to report the number of processors available on
the system. For that, it currently calls sysconf(_SC_NPROCESSORS_CONF).
However, since the operating system can disable individual processors,
we should call sysconf(_SC_NPROCESSORS_ONLN) to determine the number
of processors currently available [1]. Consequently, the once-test will
fail since pthread_setaffinity_np() is called with CPUs that are
currently not available.

It might also be advisable to change the code in the future to use CPU
sets on Linux as even the suggested change is not 100% safe but at least
it improves over the existing code. If PulseAudio was to be run in a CPU
set [2], the number of processors available to PulseAudio could be even
less than the number of CPUs currently online (_SC_NPROCESSORS_CONF).

[1] https://www.gnu.org/software/libc/manual/html_node/Processor-Resources.html
[2] http://man7.org/linux/man-pages/man7/cpuset.7.html

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=96809
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
This commit is contained in:
John Paul Adrian Glaubitz 2016-07-04 20:23:17 +02:00 • committed by Tanu Kaskinen
parent 9e4ee38c17
commit 1df21e6ab6
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pulsecore/core-util.c
View file

@ -3179,8 +3179,8 @@ void pa_reduce(unsigned *num, unsigned *den) {
unsigned pa_ncpus(void) { unsigned pa_ncpus(void) {
long ncpus; long ncpus;
#ifdef _SC_NPROCESSORS_CONF #ifdef _SC_NPROCESSORS_ONLN
ncpus = sysconf(_SC_NPROCESSORS_CONF); ncpus = sysconf(_SC_NPROCESSORS_ONLN);
#else #else
ncpus = 1; ncpus = 1;
#endif #endif