mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-07 13:30:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix pa_parse_boolean() return value checking.

Browse source 
pa_parse_boolean() return value shouldn't be stored in
pa_bool_t, because 1 and -1 need to be distinguished.
This commit is contained in:
Tanu Kaskinen 2012-03-29 15:24:02 +03:00 • committed by Tanu Kaskinen
parent 188d037150
commit 19c058dd08
3 changed files with 43 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/utils/pactl.c
View file

@ -1622,6 +1622,8 @@ int main(int argc, char *argv[]) {
module_name = argv[optind + 1];
} else if (pa_streq(argv[optind], "suspend-sink")) {
int b;
action = SUSPEND_SINK;
if (argc > optind+3 || optind+1 >= argc) {
@ -1629,12 +1631,19 @@ int main(int argc, char *argv[]) {
goto quit;
}
suspend = pa_parse_boolean(argv[argc-1]);
if ((b = pa_parse_boolean(argv[argc-1])) < 0) {
pa_log(_("Invalid suspend specification."));
goto quit;
}
suspend = !!b;
if (argc > optind+2)
sink_name = pa_xstrdup(argv[optind+1]);
} else if (pa_streq(argv[optind], "suspend-source")) {
int b;
action = SUSPEND_SOURCE;
if (argc > optind+3 || optind+1 >= argc) {
@ -1642,7 +1651,12 @@ int main(int argc, char *argv[]) {
goto quit;
}
suspend = pa_parse_boolean(argv[argc-1]);
if ((b = pa_parse_boolean(argv[argc-1])) < 0) {
pa_log(_("Invalid suspend specification."));
goto quit;
}
suspend = !!b;
if (argc > optind+2)
source_name = pa_xstrdup(argv[optind+1]);