From 0a9a1d7488387cf8ab05b8452195d2cf11388078 Mon Sep 17 00:00:00 2001 From: David Henningsson Date: Tue, 14 May 2013 11:01:13 +0200 Subject: [PATCH] alsa: Fix crash when profile_set == NULL Better check if the pointer is NULL before dereferencing it, instead of after! BugLink: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1159853 Signed-off-by: David Henningsson --- src/modules/alsa/module-alsa-card.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c index b37eabc46..fe05e3d3e 100644 --- a/src/modules/alsa/module-alsa-card.c +++ b/src/modules/alsa/module-alsa-card.c @@ -689,11 +689,11 @@ int pa__init(pa_module *m) { pa_xfree(fn); } - u->profile_set->ignore_dB = ignore_dB; - if (!u->profile_set) goto fail; + u->profile_set->ignore_dB = ignore_dB; + pa_alsa_profile_set_probe(u->profile_set, u->device_id, &m->core->default_sample_spec, m->core->default_n_fragments, m->core->default_fragment_size_msec); pa_alsa_profile_set_dump(u->profile_set);