mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-10-29 05:40:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-stream-restore: check if dbus entry exists in dbus_entries map before creating it

Browse source 
If write_entry fails to store new entry in database, next time we can try creating new entry again.
With DBUS enabled this will create another dbus entry for same name leading to crash inserting duplicate into dbus_entries map.

Fix this by checking if dbus entry exists in dbus_entries map before creating it.

Fixes: #974
This commit is contained in:
Igor V. Kovalenko 2020-10-13 09:36:50 +03:00 • committed by Arun Raghavan
parent 99b2d88282
commit 05f567086b
1 changed files with 1 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/modules/module-stream-restore.c
View file

@ -1448,13 +1448,11 @@ static void subscribe_callback(pa_core *c, pa_subscription_event_type_t t, uint3
}
#ifdef HAVE_DBUS
if (created_new_entry) {
if (!(de = pa_hashmap_get(u->dbus_entries, name))) {
de = dbus_entry_new(u, name);
pa_assert_se(pa_hashmap_put(u->dbus_entries, de->entry_name, de) == 0);
send_new_entry_signal(de);
} else {
pa_assert_se(de = pa_hashmap_get(u->dbus_entries, name));
if (device_updated)
send_device_updated_signal(de, entry);
if (volume_updated)