From 03b97d0e08ed6a8578a94970390c7347d0deb9de Mon Sep 17 00:00:00 2001 From: Colin Guthrie Date: Sun, 4 Sep 2011 21:05:14 +0200 Subject: [PATCH] formats: Export more functions needed for a clean build. All of these functions are not actually defined in format.h (they are defined in internal.h) and thus should really be included only in libpulsecommon and implemented in a separate source file. However if that approach was taken, and these functions were included in libpulsecommon, then they would have a link time dependancy on libpulse (as these four functions use other pa_format_info_* functions). As the opposite is already true (libpulse depends on libpulsecommon), this is not possible as it creates a circular dependancy. Thus the only option is to just to include these four functions in the map-file, but not actually export any public headers for them. Of course users could use this implementation by defining them in their own headers, but the only practical problem with this approach is naming conflicts which is unlikely to happen. fdo#40616 --- src/map-file | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/map-file b/src/map-file index 8e2c80157..c98ac72e6 100644 --- a/src/map-file +++ b/src/map-file @@ -165,7 +165,9 @@ pa_ext_stream_restore_test; pa_ext_stream_restore_write; pa_format_info_copy; pa_format_info_free; +pa_format_info_free2; pa_format_info_from_string; +pa_format_info_from_sample_spec; pa_format_info_is_compatible; pa_format_info_is_pcm; pa_format_info_new; @@ -179,6 +181,8 @@ pa_format_info_set_prop_string_array; pa_format_info_set_rate; pa_format_info_set_sample_format; pa_format_info_snprint; +pa_format_info_to_sample_spec; +pa_format_info_to_sample_spec_fake; pa_format_info_valid; pa_frame_size; pa_get_binary_name;