mirror of
https://gitlab.freedesktop.org/pipewire/pipewire.git
synced 2025-11-06 13:30:01 -05:00
d44bf0ffc0
Some client messages have bare ids (as opposed to proxies/resources),
eg. as in pw_registry_bind/destroy. If the client is processing
messages late, these may refer to an object that was already removed,
and the id may now refers to a differnt objects. I.e. the following
race condition needs to be resolved:
server client
Global 1 (gen. 1)
Global 1
Global 1 remove
Global 1 (gen. 2)
Bind/destroy 1
Where the client would bind/destroy the wrong global, since it did not
yet see the messages for the second one.
To keep track of which object the client means, the server keeps track of
the "generation number" of its global registry, and what generation
the client is at.
Each global remembers at what generation of registry they were
registered. When processing the messages that use bare ids, check the
registry generation of the client, to know whether the message refers to
a stale global that was already removed.
Messages where client sends bare ids to server are:
pw_registry_bind, pw_registry_destroy, metadata_set_property
In pw_registry_* do the staleness check directly. Also add staleness
check in pw_impl_client_check_permissions, so that also the metadata
case is handled.
The generation numbers are passed around in message footers, but only if
they have changed. When the generation number changes on server, we
send the updated value to the client in a message footer. When client
has received an update value, it will send the value back in the footer
of the next message it sends to the server.
Based on: Wim Taymans <wtaymans@redhat.com> "impl-core: check serial number"
|
||
|---|---|---|
| .. | ||
| module-adapter | ||
| module-client-device | ||
| module-client-node | ||
| module-filter-chain | ||
| module-metadata | ||
| module-profiler | ||
| module-protocol-native | ||
| module-protocol-pulse | ||
| module-raop | ||
| module-session-manager | ||
| module-zeroconf-discover | ||
| spa | ||
| meson.build | ||
| module-access.c | ||
| module-adapter.c | ||
| module-client-device.c | ||
| module-client-node.c | ||
| module-echo-cancel.c | ||
| module-example-sink.c | ||
| module-example-source.c | ||
| module-fallback-sink.c | ||
| module-filter-chain.c | ||
| module-link-factory.c | ||
| module-loopback.c | ||
| module-metadata.c | ||
| module-portal.c | ||
| module-profiler.c | ||
| module-protocol-native.c | ||
| module-protocol-pulse.c | ||
| module-protocol-simple.c | ||
| module-pulse-tunnel.c | ||
| module-raop-discover.c | ||
| module-raop-sink.c | ||
| module-roc-sink.c | ||
| module-roc-source.c | ||
| module-rt.c | ||
| module-session-manager.c | ||
| module-x11-bell.c | ||
| module-zeroconf-discover.c | ||