mirror of
https://gitlab.freedesktop.org/pipewire/pipewire.git
synced 2025-11-05 13:30:02 -05:00
bc2914b3e9
Move the reference counting from `pending_sample_free()` into `on_sample_done()` so that the client's references are managed in a single place. The reason why `pending_sample_free()` cannot simply call `client_unref()` is that `client_free()` may be called from `manager_disconnect()` regardless of the reference count, and, in turn, `pending_sample_free()` may be called, which could then lead to a recursive call to `client_free()`.
45 lines
1.6 KiB
C
45 lines
1.6 KiB
C
/* PipeWire
|
|
*
|
|
* Copyright © 2020 Wim Taymans
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <spa/utils/list.h>
|
|
#include <spa/utils/hook.h>
|
|
#include <pipewire/work-queue.h>
|
|
|
|
#include "client.h"
|
|
#include "internal.h"
|
|
#include "log.h"
|
|
#include "pending-sample.h"
|
|
#include "sample-play.h"
|
|
|
|
void pending_sample_free(struct pending_sample *ps)
|
|
{
|
|
struct client * const client = ps->client;
|
|
struct impl * const impl = client->impl;
|
|
|
|
spa_list_remove(&ps->link);
|
|
spa_hook_remove(&ps->listener);
|
|
pw_work_queue_cancel(impl->work_queue, ps, SPA_ID_INVALID);
|
|
|
|
sample_play_destroy(ps->play);
|
|
}
|