pipewire/spa
Alper Nebi Yasak 9b9ce21b1d acp: Don't sync hardware volumes while UCM device is disabled
The hardware controls we track for volume and mute state can change as
part of enabling or disabling the UCM device. This then triggers a
re-sync of our state with the hardware controls, which can e.g. set our
volume to an unwanted value as the result of enabling the device, or set
a hardware control to a wrong value based on our volume while disabling
the device. So these UCM-triggered changes to enable/disable the device
will at best show up on user interfaces and cause confusion, but maybe
even will push the hardware into an unexpected state.

The volume and mute state we set from user interfaces only make sense
when the devices are enabled. They should not be kept in sync with
hardware for inactive UCM devices [1]. Skip the callbacks for reading
and changing volume and mute state if the UCM device is disabled. This
way, the volume/mute controls for sinks/sources are essentially detached
from the hardware controls until the UCM device is re-enabled.

[1] https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/772#note_1872757

Link: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/772
Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
2023-12-04 15:34:48 +00:00
..
examples meson.build: fix compile with -Dexamples=disabled 2023-11-28 10:18:25 +00:00
include Fix some warnings 2023-11-21 16:32:51 +00:00
plugins acp: Don't sync hardware volumes while UCM device is disabled 2023-12-04 15:34:48 +00:00
tests Add GNU/Hurd support 2023-09-24 15:11:52 +00:00
tools treewide: use SPDX tags to specify copyright information 2023-02-16 10:54:48 +00:00
meson.build spa/meson.build: Look for udev rules in /usr by default 2023-12-02 10:08:12 +01:00