mirror of
https://gitlab.freedesktop.org/pipewire/pipewire.git
synced 2025-11-08 13:30:08 -05:00
5fed160972
The control hooks of a loop are called before the loop starts polling and after it has finished polling. Currently, this is used to implement the locking in pw_thread_loop. This is used to guarantee that the thread loop's lock is taken while the thread loop is dispatching, and that the lock can be taken while the loop is polling, when it is running no user-space code. However, calling the thread control hooks of thread A when doing an blocking invoke from thread B serves little purpose, and in fact can cause issues: for example, issuing a blocking invoke on a pw_thread_loop does not work unless the lock thereof is taken. This behaviour, of calling the control hooks from other threads, is also not documented, and goes contrary to what is currently stated in the loop.h header file: /** Executed right before waiting for events. It is typically used to * release locks. */ ... /** Executed right after waiting for events. It is typically used to * reacquire locks. */ At the moment the implementation allows any thread to queue invoke items on any other thread without restrictions; calling the control hooks only places extra restrictions on the usability of this mechanism (in case of pw_thread_loop, having to take the loop's lock). So do not call the control hooks when doing a blocking invoke. |
||
|---|---|---|
| .. | ||
| cpu-arm.c | ||
| cpu-x86.c | ||
| cpu.c | ||
| dbus.c | ||
| evl-plugin.c | ||
| evl-system.c | ||
| journal.c | ||
| logger.c | ||
| loop.c | ||
| meson.build | ||
| node-driver.c | ||
| null-audio-sink.c | ||
| plugin.c | ||
| system.c | ||