mirror of
https://gitlab.freedesktop.org/pipewire/pipewire.git
synced 2025-11-04 13:30:12 -05:00
d7793501fd
If the sample finished playing before we finished the roundtrip to get the sink_index, it will be destroyed. When the roundtrip completes, it will try to use invalid memoryy and crash. Make sure we destroy all pending replies before destroying the sample to avoid this problem. Fixes #2151
50 lines
1.7 KiB
C
50 lines
1.7 KiB
C
/* PipeWire
|
|
*
|
|
* Copyright © 2020 Wim Taymans
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <spa/utils/list.h>
|
|
#include <spa/utils/hook.h>
|
|
#include <pipewire/work-queue.h>
|
|
|
|
#include "client.h"
|
|
#include "internal.h"
|
|
#include "log.h"
|
|
#include "operation.h"
|
|
#include "pending-sample.h"
|
|
#include "sample-play.h"
|
|
|
|
void pending_sample_free(struct pending_sample *ps)
|
|
{
|
|
struct client * const client = ps->client;
|
|
struct impl * const impl = client->impl;
|
|
struct operation *o;
|
|
|
|
spa_list_remove(&ps->link);
|
|
spa_hook_remove(&ps->listener);
|
|
pw_work_queue_cancel(impl->work_queue, ps, SPA_ID_INVALID);
|
|
|
|
if ((o = operation_find(client, ps->tag)) != NULL)
|
|
operation_free(o);
|
|
|
|
sample_play_destroy(ps->play);
|
|
}
|