mirror of
https://gitlab.freedesktop.org/pipewire/pipewire.git
synced 2025-12-23 08:56:47 -05:00
314ff82ff0
The current code has several issues if a pipewiresrc is stopped and deleted while a buffer is still in use downstream. - pw_stream_queue_buffer() is never called for the corresponding pw_buffer. As a result, the busy counter is never decremented and pw_stream_dequeue_buffer() of the corresponding pipewire output will return NULL whenever it encounters this buffer. - The pipewiresrc does not own the buffer reference unless the buffer is queued in the source, so calling gst_buffer_unref() unconditionally causes refcount issues for the buffer. - buffer_recycle() can race with on_remove_buffer() and gst_pipewire_src_close(). As a result, buffer_recycle() may access pwsrc when it was already deleted. The buffer has its own reference to the pool. So the pool object lock can be used to ensure that the pwsrc, core and stream remain valid in. buffer_recycle(). If the 'dispose' function pointer was already cleared, then on_remove_buffer() has already finished, so abort early. With the pool lock held, it is save to access the pipewire loop. Now the loop lock can be used to synchronize with on_remove_buffer(). 'dispose' must be checked again in case on_remove_buffer() was triggered by something other than gst_pipewire_src_close(). In on_remove_buffer() unref the buffer if it is queued. Otherwise call pw_stream_queue_buffer() to ensure that the busy counter is decremented correctly. |
||
|---|---|---|
| .. | ||
| .editorconfig | ||
| gstpipewire.c | ||
| gstpipewireclock.c | ||
| gstpipewireclock.h | ||
| gstpipewirecore.c | ||
| gstpipewirecore.h | ||
| gstpipewiredeviceprovider.c | ||
| gstpipewiredeviceprovider.h | ||
| gstpipewireformat.c | ||
| gstpipewireformat.h | ||
| gstpipewirepool.c | ||
| gstpipewirepool.h | ||
| gstpipewiresink.c | ||
| gstpipewiresink.h | ||
| gstpipewiresrc.c | ||
| gstpipewiresrc.h | ||
| meson.build | ||