mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-18 08:56:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

avb: check seq

Browse source 
Avoid infinite loops.
Check sequence number and warn
Use 32 frames per pdu in example.
This commit is contained in:
Wim Taymans 2022-03-09 16:58:35 +01:00
parent 200f591a3d
commit ff5201ef3d
4 changed files with 41 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spa/plugins/avb/avb-pcm.c
View file

@ -757,6 +757,15 @@ static void reset_buffers(struct state *this, struct port *port)
static bool is_pdu_valid(struct state *state)
{
uint64_t val64;
if (avtp_aaf_pdu_get(state->pdu, AVTP_AAF_FIELD_SEQ_NUM, &val64) < 0)
return false;
if (state->prev_seq != 0 && (uint8_t)(state->prev_seq + 1) != val64) {
spa_log_warn(state->log, "dropped packets %d != %d", state->prev_seq + 1, (int)val64);
}
state->prev_seq = val64;
return true;
}
@ -853,6 +862,8 @@ int spa_avb_write(struct state *state)
avail = size - offs;
n_bytes = SPA_MIN(avail, to_write);
if (n_bytes == 0)
break;
spa_ringbuffer_write_data(&state->ring,
state->ringbuffer_data,
@ -976,6 +987,7 @@ static int handle_capture(struct state *state, uint64_t current_time)
spa_list_append(&port->ready, &b->link);
index += n_bytes;
avail -= n_bytes;
spa_ringbuffer_read_update(&state->ring, index);
}