mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-04-17 06:46:24 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

alsa: acp: don’t override user-selected port on availability changes

Browse source 
ACP was re-selecting the “best” port on every port availability event,
even when a port was already explicitly selected by the user. This
differs from PulseAudio’s behavior, where port switching decisions are
left to higher-level policy.

This caused issues on devices where Line Out (speakers) and Headphones
share the same analog interface: when headphones are plugged in, ACP
would immediately switch away from the user-selected Line Out, or end up
in a state where no sound is produced despite selecting speakers explicitly from
clients like pwvucontrol.

Fix this by only re-evaluating and switching ports when:
  - no active port is currently selected, or
  - the active port has become unavailable

This preserves manual user choices and prevents ACP from fighting client
port selections during route activation.

Additionally, adjust ALSA mixer paths to better separate Line Out and
Headphones behavior:
  - Disable Line Out controls in the headphones path
  - Add explicit Line Out and Auto-Mute Mode handling in the lineout path

Together, these changes align PipeWire’s behavior more closely with
PulseAudio and fix cases where selecting speakers while headphones are
plugged results in no audio output.

Signed-off-by: John Titor <masumrezarock100@gmail.com>
This commit is contained in:
Masum Reza 2026-04-16 15:54:58 +05:30 • committed by Wim Taymans
parent c551acf4d1
commit f76327e076
3 changed files with 30 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
spa/plugins/alsa/alsa-acp-device.c
View file

@ -990,11 +990,22 @@ static void card_port_available(void *data, uint32_t index,
for (i = 0; i < p->n_devices; i++) {
struct acp_device *d = p->devices[i];
struct acp_port *active_port = NULL;
uint32_t j;
uint32_t best;
if (!(d->flags & ACP_DEVICE_ACTIVE))
continue;
for (j = 0; j < d->n_ports; j++) {
if (d->ports[j]->flags & ACP_PORT_ACTIVE) {
active_port = d->ports[j];
break;
}
}
if (active_port != NULL && active_port->available != ACP_AVAILABLE_NO)
continue;
best = acp_device_find_best_port_index(d, NULL);
acp_device_set_port(d, best, 0);
}

6
spa/plugins/alsa/mixer/paths/analog-output-headphones.conf
View file

@ -93,6 +93,12 @@ volume = merge
override-map.1 = all
override-map.2 = all-left,all-right
; Keep Line Out disabled in the headphones path so selecting headphones
; does not also drive speaker/line outputs on shared controls.
[Element Line Out]
switch = off
volume = off
; This path is intended to control the first headphones, not
; the second headphones. But it should not hurt if we leave the second
; headphone jack enabled nonetheless.

13
spa/plugins/alsa/mixer/paths/analog-output-lineout.conf
View file

@ -113,10 +113,23 @@ override-map.1 = all
override-map.2 = all-left,all-right
required-any = any
[Element Line Out]
switch = mute
volume = merge
override-map.1 = all
override-map.2 = all-left,all-right
[Element Master Mono]
switch = off
volume = off
; Prefer manual routing decisions by disabling codec auto-mute here.
[Element Auto-Mute Mode]
enumeration = select
[Option Auto-Mute Mode:Disabled]
name = analog-output-lineout
[Element Line HP Swap]
switch = off
required-any = any