From f64c21ed81280ca48859d5fc73ee6f4b0fc40fdd Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Fri, 7 Apr 2023 16:45:28 +0200 Subject: [PATCH] filter-chain: fix bq_raw activate The raw biquad takes its values from the config and then updates the control ports with them in activate. At runtime, the changes to the ports are applied to the biquad. Other biquads take values from the config ports in activate. --- src/modules/module-filter-chain/builtin_plugin.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/modules/module-filter-chain/builtin_plugin.c b/src/modules/module-filter-chain/builtin_plugin.c index 2147de74e..7577c8890 100644 --- a/src/modules/module-filter-chain/builtin_plugin.c +++ b/src/modules/module-filter-chain/builtin_plugin.c @@ -448,14 +448,12 @@ static void bq_activate(void * Instance) { struct builtin *impl = Instance; if (impl->type == BQ_NONE) { - float b0, b1, b2, a0, a1, a2; - b0 = impl->port[5][0]; - b1 = impl->port[6][0]; - b2 = impl->port[7][0]; - a0 = impl->port[8][0]; - a1 = impl->port[9][0]; - a2 = impl->port[10][0]; - bq_raw_update(impl, b0, b1, b2, a0, a1, a2); + impl->port[5][0] = impl->b0; + impl->port[6][0] = impl->b1; + impl->port[7][0] = impl->b2; + impl->port[8][0] = impl->a0; + impl->port[9][0] = impl->a1; + impl->port[10][0] = impl->a2; } else { float freq = impl->port[2][0]; float Q = impl->port[3][0];