mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-16 08:56:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

conf: fix fork/execvp/waitpid usage

Browse source 
In context.exec after forking, if execvp returns we have to exit since
we're in the child process.

To avoid zombies, either SIGCHLD need to be handled/ignored, or
double-fork to create orphan processes. This is in library code, so it
seems best to just double-fork.
This commit is contained in:
Pauli Virtanen 2022-02-13 15:08:52 +02:00
parent 0b40d36a14
commit f5d47c079e
1 changed files with 20 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/pipewire/conf.c
View file

@ -734,6 +734,16 @@ static int do_exec(struct pw_context *context, const char *key, const char *args
if (pid == 0) {
char *cmd, **argv;
/* Double fork to avoid zombies; we don't want to set SIGCHLD handler */
pid = fork();
if (pid < 0) {
pw_log_error("fork error: %m");
exit(1);
} else if (pid != 0) {
exit(0);
}
cmd = spa_aprintf("%s %s", key, args ? args : "");
argv = pw_split_strv(cmd, " \t", INT_MAX, &n_args);
free(cmd);
@ -745,13 +755,18 @@ static int do_exec(struct pw_context *context, const char *key, const char *args
if (res == -1) {
res = -errno;
pw_log_error("execvp error '%s': %m", key);
return res;
}
}
else {
exit(1);
} else if (pid < 0) {
pw_log_error("fork error: %m");
} else {
int status = 0;
res = waitpid(pid, &status, WNOHANG);
pw_log_info("exec got pid %d res:%d status:%d", pid, res, status);
do {
errno = 0;
res = waitpid(pid, &status, 0);
} while (res < 0 && errno == EINTR);
pw_log_debug("exec got pid %d res:%d status:%d", (int)pid, res, status);
}
return 0;
}