From f4558472df98a6c36547bdac45a2d1542f02b9d8 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Thu, 12 Mar 2026 15:00:34 +0100 Subject: [PATCH] Revert "pipewire-jack: emit foreign port registration callbacks on jack_activate" This reverts commit b0065bfe9a8d34020e2ea6f4272f3a2b28601689. This causes double ports in carla. --- pipewire-jack/src/pipewire-jack.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pipewire-jack/src/pipewire-jack.c b/pipewire-jack/src/pipewire-jack.c index d34d96bd6..94482dbc0 100644 --- a/pipewire-jack/src/pipewire-jack.c +++ b/pipewire-jack/src/pipewire-jack.c @@ -4886,15 +4886,9 @@ int jack_activate (jack_client_t *client) c->activation->pending_new_pos = true; c->activation->pending_sync = true; - /* emits all foreign active ports, skips own (already announced via jack_port_register) */ spa_list_for_each(o, &c->context.objects, link) { - if (o->type != INTERFACE_Port || o->removed) - continue; - /* own ports are handled by jack_port_register */ - if (o->port.port != NULL && o->port.port->client == c) - continue; - /* only announce ports whose node is active */ - if (o->port.node != NULL && !node_is_active(c, o->port.node)) + if (o->type != INTERFACE_Port || o->port.port == NULL || + o->port.port->client != c || !o->port.port->valid) continue; o->registered = 0; queue_notify(c, NOTIFY_TYPE_PORTREGISTRATION, o, 1, NULL);