From f4021c7f443ba7a8359e17f52259a91ae5d744ad Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Sun, 23 Jan 2022 10:16:42 +0100 Subject: [PATCH] port: add some more warnings when unregister fails --- pipewire-jack/src/pipewire-jack.c | 6 ++++-- src/pipewire/impl-port.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/pipewire-jack/src/pipewire-jack.c b/pipewire-jack/src/pipewire-jack.c index 5a4163c9c..2e7af470f 100644 --- a/pipewire-jack/src/pipewire-jack.c +++ b/pipewire-jack/src/pipewire-jack.c @@ -4221,9 +4221,11 @@ int jack_port_unregister (jack_client_t *client, jack_port_t *port) 0, 0, NULL, NULL); res = do_sync(c); - + if (res < 0) { + pw_log_warn("can't unregister port %s: %s", o->port.name, + spa_strerror(res)); + } free_port(c, p); - done: pw_thread_loop_unlock(c->context.loop); diff --git a/src/pipewire/impl-port.c b/src/pipewire/impl-port.c index 1b1d0d7c1..3666dc154 100644 --- a/src/pipewire/impl-port.c +++ b/src/pipewire/impl-port.c @@ -1076,10 +1076,12 @@ static void pw_impl_port_remove(struct pw_impl_port *port) } if (port->direction == PW_DIRECTION_INPUT) { - pw_map_insert_at(&node->input_port_map, port->port_id, NULL); + if ((res = pw_map_insert_at(&node->input_port_map, port->port_id, NULL)) < 0) + pw_log_warn("%p: can't remove input port: %s", port, spa_strerror(res)); node->info.n_input_ports--; } else { - pw_map_insert_at(&node->output_port_map, port->port_id, NULL); + if ((res = pw_map_insert_at(&node->output_port_map, port->port_id, NULL)) < 0) + pw_log_warn("%p: can't remove output port: %s", port, spa_strerror(res)); node->info.n_output_ports--; }