mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pipewire-jack: use jack_client_close() to free client in error path

Browse source 
The client needs to be cleaned up properly, otherwise references
to its storage may remain, which can later result in use-after-frees.
For example, the via the various embedded `spa_hook`s in it.

See #2394
This commit is contained in:
Barnabás Pőcze 2022-06-03 01:26:58 +02:00
parent c6a5698eac
commit f2c53622d2
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pipewire-jack/src/pipewire-jack.c
View file

@ -3436,7 +3436,7 @@ server_failed:
exit_unlock: exit_unlock:
pw_thread_loop_unlock(client->context.loop); pw_thread_loop_unlock(client->context.loop);
exit: exit:
free(client); jack_client_close((jack_client_t *) client);
return NULL; return NULL;
disabled: disabled:
if (status) if (status)