From f11cd32258927aa7f00a771cc5eba0f1068d5779 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Fri, 1 May 2020 11:24:14 +0200 Subject: [PATCH] node: improve warnings Make separate warnings for read failure and xrun --- src/pipewire/impl-node.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pipewire/impl-node.c b/src/pipewire/impl-node.c index ce1cb554a..f0f947efe 100644 --- a/src/pipewire/impl-node.c +++ b/src/pipewire/impl-node.c @@ -931,8 +931,10 @@ static void node_on_fd_events(struct spa_source *source) if (SPA_LIKELY(source->rmask & SPA_IO_IN)) { uint64_t cmd; - if (SPA_UNLIKELY(spa_system_eventfd_read(data_system, this->source.fd, &cmd) < 0 || cmd != 1)) - pw_log_warn(NAME" %p: read %"PRIu64" failed %m", this, cmd); + if (SPA_UNLIKELY(spa_system_eventfd_read(data_system, this->source.fd, &cmd) < 0)) + pw_log_warn(NAME" %p: read failed %m", this); + if (SPA_UNLIKELY(cmd > 1)) + pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", this, cmd - 1); pw_log_trace_fp(NAME" %p: got process", this); this->rt.target.signal(this->rt.target.data);