mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-06-04 03:03:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-avb: SET_NAME: check that string is valid utf8 and zero padded

Browse source
This commit is contained in:
Nils Tonnaett 2026-05-13 11:59:45 -07:00 • committed by Wim Taymans
parent 14b1c4d3dd
commit ef77d995cd
1 changed files with 9 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/modules/module-avb/aecp-aem-cmds-resps/cmd-get-set-name.c
View file

@ -146,7 +146,6 @@ int handle_cmd_get_name_common(struct aecp *aecp, int64_t now,
/** /**
* IEEE 1722.1-2021 7.4.17 SET_NAME * IEEE 1722.1-2021 7.4.17 SET_NAME
* For now this is not handling UTF characters, only ASCII
*/ */
int handle_cmd_set_name_common(struct aecp *aecp, int64_t now, int handle_cmd_set_name_common(struct aecp *aecp, int64_t now,
const void *m, int len) const void *m, int len)
@ -182,14 +181,17 @@ int handle_cmd_set_name_common(struct aecp *aecp, int64_t now,
/** /**
* IEEE 1722.1-2021: 7.4.17.1: The name does not contain a trailing NULL * IEEE 1722.1-2021: 7.4.17.1: The name does not contain a trailing NULL
* but if the name is less than 64 bytes in length then it is zero * but if the name is less than 64 bytes in length then it is zero
* padded * padded.
*/ */
memcpy(name_ptr, cmd->name, 64); if (check_zero_padding(cmd->name, 64) == -1)
return reply_status(aecp,
AVB_AECP_AEM_STATUS_BAD_ARGUMENTS, m, len);
/** TODO: According to the specification, the string should alwasy be 0 if (validate_utf8(cmd->name, 64) == -1)
* terminated, the goal would be to check whether a string is UTF-8 and return reply_status(aecp,
* that it is correctly zero terminitaed if less than 64 char, if not AVB_AECP_AEM_STATUS_BAD_ARGUMENTS, m, len);
* then a simple memcpy is enough */
memcpy(name_ptr, cmd->name, 64);
rc = reply_success(aecp, m, len); rc = reply_success(aecp, m, len);
if (rc < 0) if (rc < 0)