mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pod: avoid modulo by 0

Browse source 
a % b is undefined behavior if b is 0.
This commit is contained in:
Demi Marie Obenour 2025-07-10 12:10:28 -04:00 • committed by Wim Taymans
parent fb315b9050
commit edef57f6c3
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spa/include/spa/pod/compare.h
View file

@ -205,11 +205,11 @@ SPA_API_POD_COMPARE int spa_pod_compare_is_step_of(uint32_t type, const void *r1
{ {
switch (type) { switch (type) {
case SPA_TYPE_Int: case SPA_TYPE_Int:
if (size < sizeof(int32_t)) if (size < sizeof(int32_t) || *(int32_t *)r2 < 1)
return -EINVAL; return -EINVAL;
return *(int32_t *) r1 % *(int32_t *) r2 == 0; return *(int32_t *) r1 % *(int32_t *) r2 == 0;
case SPA_TYPE_Long: case SPA_TYPE_Long:
if (size < sizeof(int64_t)) if (size < sizeof(int64_t) || *(int64_t *)r2 < 1)
return -EINVAL; return -EINVAL;
return *(int64_t *) r1 % *(int64_t *) r2 == 0; return *(int64_t *) r1 % *(int64_t *) r2 == 0;
case SPA_TYPE_Rectangle: case SPA_TYPE_Rectangle:
@ -217,8 +217,12 @@ SPA_API_POD_COMPARE int spa_pod_compare_is_step_of(uint32_t type, const void *r1
const struct spa_rectangle *rec1 = (struct spa_rectangle *) r1, const struct spa_rectangle *rec1 = (struct spa_rectangle *) r1,
*rec2 = (struct spa_rectangle *) r2; *rec2 = (struct spa_rectangle *) r2;
if (size < sizeof(struct spa_rectangle)) if (size < sizeof(struct spa_rectangle) ||
rec2->width < 1 ||
rec2->height < 1)
{
return -EINVAL; return -EINVAL;
}
return (rec1->width % rec2->width == 0 && return (rec1->width % rec2->width == 0 &&
rec1->height % rec2->height == 0); rec1->height % rec2->height == 0);
} }