mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-05-07 12:06:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

modules: free the stream and impl on errors

Browse source
This commit is contained in:
Wim Taymans 2026-05-07 13:30:12 +02:00
parent aa36fd5a17
commit e9aff3040a
2 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/modules/module-rtp/stream.c
View file

@ -926,8 +926,7 @@ struct rtp_stream *rtp_stream_new(struct pw_core *core,
spa_dll_set_bw(&impl->dll, SPA_DLL_BW_MIN, 128, impl->rate);
impl->corr = 1.0;
impl->stream = pw_stream_new(core, "rtp-session", props);
props = NULL;
impl->stream = pw_stream_new(core, "rtp-session", spa_steal_ptr(props));
if (impl->stream == NULL) {
res = -errno;
pw_log_error("can't create stream: %m");
@ -1014,6 +1013,11 @@ struct rtp_stream *rtp_stream_new(struct pw_core *core,
return (struct rtp_stream*)impl;
out:
pw_properties_free(props);
if (impl) {
if (impl->stream)
pw_stream_destroy(impl->stream);
free(impl);
}
errno = -res;
return NULL;
}

9
src/modules/module-vban/stream.c
View file

@ -250,7 +250,6 @@ struct vban_stream *vban_stream_new(struct pw_core *core,
if (impl == NULL) {
res = -errno;
goto out;
return NULL;
}
impl->first = true;
spa_hook_list_init(&impl->listener_list);
@ -388,8 +387,7 @@ struct vban_stream *vban_stream_new(struct pw_core *core,
spa_dll_set_bw(&impl->dll, SPA_DLL_BW_MAX, 128, impl->rate);
impl->corr = 1.0;
impl->stream = pw_stream_new(core, "vban-session", props);
props = NULL;
impl->stream = pw_stream_new(core, "vban-session", spa_steal_ptr(props));
if (impl->stream == NULL) {
res = -errno;
pw_log_error("can't create stream: %m");
@ -443,6 +441,11 @@ struct vban_stream *vban_stream_new(struct pw_core *core,
return (struct vban_stream*)impl;
out:
pw_properties_free(props);
if (impl) {
if (impl->stream)
pw_stream_destroy(impl->stream);
free(impl);
}
errno = -res;
return NULL;
}