mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

spa: libcamera: source: use dynamic builder for controls

Browse source 
Use a dynamic spa pod builder when enumerating controls since previous
changes can report more information from any given control. Also increase
the stack buffer size to 4096 bytes.
This commit is contained in:
Barnabás Pőcze 2025-08-05 15:08:00 +02:00 • committed by Wim Taymans
parent 8673f17c0a
commit e6f767d41d
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spa/plugins/libcamera/libcamera-source.cpp
View file

@ -33,6 +33,7 @@
#include <spa/param/param.h>
#include <spa/param/latency-utils.h>
#include <spa/control/control.h>
#include <spa/pod/dynamic.h>
#include <spa/pod/filter.h>
#include <libcamera/camera.h>
@ -883,8 +884,9 @@ spa_libcamera_enum_controls(struct impl *impl, struct port *port, int seq,
const struct spa_pod *filter)
{
const ControlInfoMap &info = impl->camera->controls();
uint8_t buffer[1024];
struct spa_pod_builder b = { 0 };
spa_auto(spa_pod_dynamic_builder) b = {};
spa_pod_builder_state state;
uint8_t buffer[4096];
spa_result_node_params result = {
.id = SPA_PARAM_PropInfo,
};
@ -893,18 +895,21 @@ spa_libcamera_enum_controls(struct impl *impl, struct port *port, int seq,
for (auto skip = start - offset; skip && it != info.end(); skip--)
it++;
spa_pod_dynamic_builder_init(&b, buffer, sizeof(buffer), 4096);
spa_pod_builder_get_state(&b.b, &state);
for (result.index = start; num > 0 && it != info.end(); ++it, result.index++) {
spa_log_debug(impl->log, "%p: controls[%" PRIu32 "]: %s::%s",
impl, result.index, it->first->vendor().c_str(),
it->first->name().c_str());
spa_pod_builder_init(&b, buffer, sizeof(buffer));
spa_pod_builder_reset(&b.b, &state);
const auto *ctrl = control_details_to_pod(b, *it->first, it->second);
const auto *ctrl = control_details_to_pod(b.b, *it->first, it->second);
if (!ctrl)
continue;
if (spa_pod_filter(&b, &result.param, ctrl, filter) < 0)
if (spa_pod_filter(&b.b, &result.param, ctrl, filter) < 0)
continue;
result.next = result.index + 1;