From e42fd9301b3e4a13768b5de2ad98e398aaef6f67 Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Thu, 14 Dec 2017 18:45:55 +0100
Subject: [PATCH] client: warn for invalid global ids

---
 src/pipewire/client.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/pipewire/client.c b/src/pipewire/client.c
index 2a46fcb6d..36771e54a 100644
--- a/src/pipewire/client.c
+++ b/src/pipewire/client.c
@@ -425,15 +425,19 @@ void pw_client_update_permissions(struct pw_client *client, const struct spa_dic
 		}
 		else if (strcmp(dict->items[i].key, PW_CORE_PROXY_PERMISSIONS_GLOBAL) == 0) {
 			struct pw_global *global;
+			uint32_t global_id;
 
 			/* permissions.update=<global-id>:[r][w][x] */
 			len = strcspn(str, ":");
 			if (len == 0)
 				continue;
 
-			global = pw_core_find_global(client->core, atoi(str));
-			if (global == NULL)
+			global_id = atoi(str);
+			global = pw_core_find_global(client->core, global_id);
+			if (global == NULL) {
+				pw_log_warn("client %p: invalid global %d", client, global_id);
 				continue;
+			}
 
 			update.permissions = parse_mask(str + len);
 			update.only_new = false;