From e27ec1a2031e159afc11840331384360ade70268 Mon Sep 17 00:00:00 2001 From: Linus Svensson Date: Wed, 12 Apr 2017 11:23:00 +0200 Subject: [PATCH] Only use string literals as format Fixes -Wformat-security error. --- pinos/modules/module-protocol-dbus.c | 3 ++- spa/lib/debug.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/pinos/modules/module-protocol-dbus.c b/pinos/modules/module-protocol-dbus.c index 7375ac095..499ca7fed 100644 --- a/pinos/modules/module-protocol-dbus.c +++ b/pinos/modules/module-protocol-dbus.c @@ -408,7 +408,8 @@ handle_create_client_node (PinosDaemon1 *interface, target_node = pinos_properties_get (props, "pinos.target.node"); if (target_node) { if (strncmp (target_node, "/org/pinos/node_", strlen ("/org/pinos/node_")) == 0) { - pinos_properties_setf (props, "pinos.target.node", target_node + strlen ("/org/pinos/node_")); + pinos_properties_setf (props, "pinos.target.node", "%s", + target_node + strlen ("/org/pinos/node_")); } } diff --git a/spa/lib/debug.c b/spa/lib/debug.c index 23d439411..16f4ca114 100644 --- a/spa/lib/debug.c +++ b/spa/lib/debug.c @@ -412,7 +412,7 @@ spa_debug_format (const SpaFormat *format, const SpaTypeMap *map) break; } - fprintf (stderr, ssep); + fprintf (stderr, "%s", ssep); i = 0; SPA_POD_PROP_ALTERNATIVE_FOREACH (&prop->body, prop->pod.size, alt) { @@ -421,7 +421,7 @@ spa_debug_format (const SpaFormat *format, const SpaTypeMap *map) print_format_value (map, prop->body.value.size, prop->body.value.type, alt); i++; } - fprintf (stderr, esep); + fprintf (stderr, "%s", esep); } fprintf (stderr, "\n"); }