From e24d7cc8b7502e683d44d21b10bfd9849ef7d708 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 3 May 2023 13:04:58 +0200 Subject: [PATCH] module-jack: don't crash when NULL source/sink It is possible that we destroyed the source/sink when we get a latency update from jack, don't try to update the source/sink in that case or we will crash. --- src/modules/module-jack-tunnel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/module-jack-tunnel.c b/src/modules/module-jack-tunnel.c index 27e1edb48..615f487ae 100644 --- a/src/modules/module-jack-tunnel.c +++ b/src/modules/module-jack-tunnel.c @@ -526,7 +526,8 @@ do_update_latency(struct spa_loop *loop, SPA_PARAM_Latency, &impl->sink_latency[SPA_DIRECTION_INPUT]); impl->sink_latency_changed[SPA_DIRECTION_INPUT] = false; } - pw_stream_update_params(impl->sink, params, n_params); + if (impl->sink) + pw_stream_update_params(impl->sink, params, n_params); } if ((impl->mode & MODE_SOURCE)) { @@ -536,7 +537,8 @@ do_update_latency(struct spa_loop *loop, SPA_PARAM_Latency, &impl->source_latency[SPA_DIRECTION_OUTPUT]); impl->source_latency_changed[SPA_DIRECTION_OUTPUT] = false; } - pw_stream_update_params(impl->source, params, n_params); + if (impl->source) + pw_stream_update_params(impl->source, params, n_params); } return 0; }