mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

modules: fix missing free/close and length checks

Browse source 
Fix some missing free and close.

Fix not checking length of received netjack data.
This commit is contained in:
Pauli Virtanen 2025-06-14 15:24:05 +03:00
parent baadda3b67
commit dc618d37c6
3 changed files with 13 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/modules/module-protocol-simple.c
View file

@ -665,8 +665,9 @@ static int make_tcp_socket(struct server *server, const char *name, const char *
const char *ifaddress)
{
struct sockaddr_storage addr;
int res, fd, on;
int res, on;
socklen_t len = 0;
spa_autoclose int fd = -1;
if ((res = pw_net_parse_address_port(name, ifaddress, DEFAULT_PORT, &addr, &len)) < 0) {
pw_log_error("%p: can't parse address %s: %s", server,
@ -693,26 +694,24 @@ static int make_tcp_socket(struct server *server, const char *name, const char *
if (bind(fd, (struct sockaddr *) &addr, len) < 0) {
res = -errno;
pw_log_error("%p: bind() failed: %m", server);
goto error_close;
goto error;
}
if (listen(fd, 5) < 0) {
res = -errno;
pw_log_error("%p: listen() failed: %m", server);
goto error_close;
goto error;
}
if (getsockname(fd, (struct sockaddr *)&addr, &len) < 0) {
res = -errno;
pw_log_error("%p: getsockname() failed: %m", server);
goto error_close;
goto error;
}
server->type = SERVER_TYPE_TCP;
server->addr = addr;
return fd;
return spa_steal_fd(fd);
error_close:
close(fd);
error:
return res;
}