From db7b764bf2a8a938c47344ce8b2d892ac7ad7e0c Mon Sep 17 00:00:00 2001 From: Pauli Virtanen Date: Wed, 31 Jan 2024 21:40:26 +0200 Subject: [PATCH] bluez5: deprioritize AAC-ELD since it's untested The AAC-ELD support was not properly tested on devices. In theory it should be OK, but it's untested. Bump it down in priority so it won't be selected by default. Also log info on FDK-AAC AAC-ELD support status. --- spa/plugins/bluez5/a2dp-codec-aac.c | 1 + spa/plugins/bluez5/codec-loader.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/spa/plugins/bluez5/a2dp-codec-aac.c b/spa/plugins/bluez5/a2dp-codec-aac.c index 30e5ae9b6..5420e9144 100644 --- a/spa/plugins/bluez5/a2dp-codec-aac.c +++ b/spa/plugins/bluez5/a2dp-codec-aac.c @@ -63,6 +63,7 @@ done: if (aacenc) aacEncClose(&aacenc); checked = true; + spa_log_debug(log, "FDK-AAC AAC-ELD support:%d", (int)supported); return supported; } diff --git a/spa/plugins/bluez5/codec-loader.c b/spa/plugins/bluez5/codec-loader.c index 47970d295..e38c9c786 100644 --- a/spa/plugins/bluez5/codec-loader.c +++ b/spa/plugins/bluez5/codec-loader.c @@ -35,7 +35,6 @@ static int codec_order(const struct media_codec *c) SPA_BLUETOOTH_AUDIO_CODEC_LDAC, SPA_BLUETOOTH_AUDIO_CODEC_APTX_HD, SPA_BLUETOOTH_AUDIO_CODEC_APTX, - SPA_BLUETOOTH_AUDIO_CODEC_AAC_ELD, SPA_BLUETOOTH_AUDIO_CODEC_AAC, SPA_BLUETOOTH_AUDIO_CODEC_LC3PLUS_HR, SPA_BLUETOOTH_AUDIO_CODEC_MPEG, @@ -50,6 +49,7 @@ static int codec_order(const struct media_codec *c) SPA_BLUETOOTH_AUDIO_CODEC_OPUS_05_71, SPA_BLUETOOTH_AUDIO_CODEC_OPUS_05_DUPLEX, SPA_BLUETOOTH_AUDIO_CODEC_OPUS_05_PRO, + SPA_BLUETOOTH_AUDIO_CODEC_AAC_ELD, }; size_t i; for (i = 0; i < SPA_N_ELEMENTS(order); ++i)