mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-04-30 06:46:49 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

overflow: fix some more potential overflows

Browse source
This commit is contained in:
Wim Taymans 2026-04-27 12:29:31 +02:00
parent fb4e148985
commit daa66c0646
5 changed files with 48 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

19
spa/plugins/audioconvert/audioconvert.c
View file

@ -14,6 +14,7 @@
#include <spa/support/loop.h>
#include <spa/support/log.h>
#include <spa/support/plugin-loader.h>
#include <spa/utils/overflow.h>
#include <spa/utils/result.h>
#include <spa/utils/list.h>
#include <spa/utils/json.h>
@ -1285,24 +1286,28 @@ static int ensure_tmp(struct impl *this)
uint32_t maxsize = this->maxsize, maxports = this->maxports;
uint32_t i;
float *empty, *scratch, *tmp[2];
size_t alloc_size;
if (spa_overflow_add((size_t)maxsize, (size_t)MAX_ALIGN, &alloc_size))
return -ENOMEM;
if (maxsize > this->scratch_size) {
spa_log_info(this->log, "resize tmp %d -> %d", this->scratch_size, maxsize);
if ((empty = realloc(this->empty, maxsize + MAX_ALIGN)) != NULL)
if ((empty = realloc(this->empty, alloc_size)) != NULL)
this->empty = empty;
if ((scratch = realloc(this->scratch, maxsize + MAX_ALIGN)) != NULL)
if ((scratch = realloc(this->scratch, alloc_size)) != NULL)
this->scratch = scratch;
if (empty == NULL || scratch == NULL) {
free_tmp(this);
return -ENOMEM;
}
memset(this->empty, 0, maxsize + MAX_ALIGN);
memset(this->empty, 0, alloc_size);
for (i = 0; i < this->scratch_ports; i++) {
if ((tmp[0] = realloc(this->tmp[0][i], maxsize + MAX_ALIGN)) != NULL)
if ((tmp[0] = realloc(this->tmp[0][i], alloc_size)) != NULL)
this->tmp[0][i] = tmp[0];
if ((tmp[1] = realloc(this->tmp[1][i], maxsize + MAX_ALIGN)) != NULL)
if ((tmp[1] = realloc(this->tmp[1][i], alloc_size)) != NULL)
this->tmp[1][i] = tmp[1];
if (tmp[0] == NULL || tmp[1] == NULL) {
free_tmp(this);
@ -1317,9 +1322,9 @@ static int ensure_tmp(struct impl *this)
spa_log_info(this->log, "resize ports %d -> %d", this->scratch_ports, maxports);
for (i = this->scratch_ports; i < maxports; i++) {
if ((tmp[0] = malloc(maxsize + MAX_ALIGN)) != NULL)
if ((tmp[0] = malloc(alloc_size)) != NULL)
this->tmp[0][i] = tmp[0];
if ((tmp[1] = malloc(maxsize + MAX_ALIGN)) != NULL)
if ((tmp[1] = malloc(alloc_size)) != NULL)
this->tmp[1][i] = tmp[1];
if (tmp[0] == NULL || tmp[1] == NULL) {
free_tmp(this);

18
spa/plugins/audioconvert/fmt-ops.c
View file

@ -8,6 +8,7 @@
#include <spa/support/cpu.h>
#include <spa/utils/defs.h>
#include <spa/utils/overflow.h>
#include <spa/param/audio/format-utils.h>
#include "fmt-ops.h"
@ -551,7 +552,8 @@ int convert_init(struct convert *conv)
const struct dither_info *dinfo;
const struct noise_info *ninfo;
const struct clear_info *cinfo;
uint32_t i, conv_flags, data_size[4];
uint32_t i, conv_flags;
size_t data_size[4];
/* we generate int32 bits of random values. With this scale
* factor, we bring this in the [-1.0, 1.0] range */
@ -615,10 +617,18 @@ int convert_init(struct convert *conv)
data_size[0] = SPA_ROUND_UP(conv->noise_size * sizeof(float), FMT_OPS_MAX_ALIGN);
data_size[1] = SPA_ROUND_UP(RANDOM_SIZE * sizeof(uint32_t), FMT_OPS_MAX_ALIGN);
data_size[2] = SPA_ROUND_UP(RANDOM_SIZE * sizeof(int32_t), FMT_OPS_MAX_ALIGN);
data_size[3] = SPA_ROUND_UP(conv->n_channels * sizeof(struct shaper), FMT_OPS_MAX_ALIGN);
if (spa_overflow_mul((size_t)conv->n_channels, sizeof(struct shaper), &data_size[3]))
return -ENOMEM;
data_size[3] = SPA_ROUND_UP(data_size[3], FMT_OPS_MAX_ALIGN);
conv->data = calloc(FMT_OPS_MAX_ALIGN +
data_size[0] + data_size[1] + data_size[2] + data_size[3], 1);
size_t total_size = FMT_OPS_MAX_ALIGN;
if (spa_overflow_add(total_size, data_size[0], &total_size) ||
spa_overflow_add(total_size, data_size[1], &total_size) ||
spa_overflow_add(total_size, data_size[2], &total_size) ||
spa_overflow_add(total_size, data_size[3], &total_size))
return -ENOMEM;
conv->data = calloc(total_size, 1);
if (conv->data == NULL)
return -errno;

16
spa/plugins/filter-graph/filter-graph.c
View file

@ -15,6 +15,7 @@
#include <limits.h>
#include <math.h>
#include <spa/utils/overflow.h>
#include <spa/utils/result.h>
#include <spa/utils/string.h>
#include <spa/utils/json.h>
@ -1918,9 +1919,15 @@ static int setup_graph(struct graph *graph)
spa_log_info(impl->log, "using %d instances %d %d", n_hndl, n_input, n_output);
graph->n_input = 0;
graph->input = calloc(n_input * 16 * n_hndl, sizeof(struct graph_port));
size_t input_count, output_count;
if (spa_overflow_mul((size_t)n_input, (size_t)16, &input_count) ||
spa_overflow_mul(input_count, (size_t)n_hndl, &input_count))
return -ENOMEM;
graph->input = calloc(input_count, sizeof(struct graph_port));
graph->n_output = 0;
graph->output = calloc(n_output * n_hndl, sizeof(struct graph_port));
if (spa_overflow_mul((size_t)n_output, (size_t)n_hndl, &output_count))
return -ENOMEM;
graph->output = calloc(output_count, sizeof(struct graph_port));
/* now collect all input and output ports for all the handles. */
for (i = 0; i < n_hndl; i++) {
@ -2059,7 +2066,10 @@ static int setup_graph(struct graph *graph)
}
graph->n_hndl = 0;
graph->hndl = calloc(graph->n_nodes * n_hndl, sizeof(struct graph_hndl));
size_t hndl_count;
if (spa_overflow_mul((size_t)graph->n_nodes, (size_t)n_hndl, &hndl_count))
return -ENOMEM;
graph->hndl = calloc(hndl_count, sizeof(struct graph_hndl));
/* order all nodes based on dependencies, first reset fields */
sort_reset(graph);
while ((node = sort_next_node(graph)) != NULL) {

9
spa/plugins/videoconvert/videoadapter.c
View file

@ -358,6 +358,7 @@ static void emit_node_info(struct impl *this, bool full)
if (this->info.props)
n_items = this->info.props->n_items;
n_items = SPA_MIN(n_items, 1024u);
items = alloca((n_items + 2) * sizeof(struct spa_dict_item));
for (i = 0; i < n_items; i++)
items[i] = this->info.props->items[i];
@ -518,6 +519,9 @@ static int negotiate_buffers(struct impl *this)
align = SPA_MAX(align, this->max_align);
if (blocks > 4096)
return -ENOMEM;
datas = alloca(sizeof(struct spa_data) * blocks);
memset(datas, 0, sizeof(struct spa_data) * blocks);
aligns = alloca(sizeof(uint32_t) * blocks);
@ -1910,9 +1914,10 @@ static int load_converter(struct impl *this, const struct spa_dict *info,
char direction[16];
uint32_t i;
items = alloca((info->n_items + 1) * sizeof(struct spa_dict_item));
uint32_t n_items = SPA_MIN(info->n_items, 1024u);
items = alloca((n_items + 1) * sizeof(struct spa_dict_item));
cinfo = SPA_DICT(items, 0);
for (i = 0; i < info->n_items; i++)
for (i = 0; i < n_items; i++)
items[cinfo.n_items++] = info->items[i];
snprintf(direction, sizeof(direction), "%s",