mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-06 13:30:01 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

link: check permissions

Browse source 
When creating a link between two nodes, check if the owner of a
node (when it is a client) can see the other node.
This commit is contained in:
Wim Taymans 2019-05-13 12:51:20 +02:00
parent 3854f8557a
commit d7acbb222e
1 changed files with 28 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/pipewire/link.c
View file

@ -1086,6 +1086,28 @@ static const struct pw_node_events output_node_events = {
.async_complete = output_node_async_complete, .async_complete = output_node_async_complete,
}; };
static int
check_permission(struct pw_core *core,
struct pw_port *output,
struct pw_port *input,
struct pw_properties *properties)
{
struct pw_node *input_node, *output_node;
struct pw_client *client;
input_node = input->node;
output_node = output->node;
if ((client = output_node->global->owner) != NULL &&
!PW_PERM_IS_R(pw_global_get_permissions(input_node->global, client)))
return -EPERM;
if ((client = input_node->global->owner) != NULL &&
!PW_PERM_IS_R(pw_global_get_permissions(output_node->global, client)))
return -EPERM;
return 0;
}
SPA_EXPORT SPA_EXPORT
struct pw_link *pw_link_new(struct pw_core *core, struct pw_link *pw_link_new(struct pw_core *core,
struct pw_port *output, struct pw_port *output,
@ -1105,6 +1127,9 @@ struct pw_link *pw_link_new(struct pw_core *core,
if (pw_link_find(output, input)) if (pw_link_find(output, input))
goto link_exists; goto link_exists;
if (check_permission(core, output, input, properties) < 0)
goto link_not_allowed;
impl = calloc(1, sizeof(struct impl) + user_data_size); impl = calloc(1, sizeof(struct impl) + user_data_size);
if (impl == NULL) if (impl == NULL)
goto no_mem; goto no_mem;
@ -1202,6 +1227,9 @@ struct pw_link *pw_link_new(struct pw_core *core,
link_exists: link_exists:
asprintf(error, "link already exists"); asprintf(error, "link already exists");
return NULL; return NULL;
link_not_allowed:
asprintf(error, "link not allowed");
return NULL;
no_mem: no_mem:
asprintf(error, "no memory"); asprintf(error, "no memory");
return NULL; return NULL;