mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

stream: decouple the requested size from scheduling

Browse source 
The docs say that a requested size of 0 can be returned and it means
that there is no suggestion for the size.

Make this so by decoupling the requested size value and the triggering
of the process callback. If we have no rate_match and no quantum
(because the driver didn't set it) we still want to schedule with a 0
requested size.
This commit is contained in:
Wim Taymans 2025-09-09 15:11:45 +02:00
parent 1e5a938e43
commit d6488c5351
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/pipewire/stream.c
View file

@ -97,6 +97,7 @@ struct stream {
struct spa_io_buffers *io;
struct spa_io_rate_match *rate_match;
uint32_t rate_queued;
uint32_t have_requested;
uint64_t rate_size;
uint64_t port_change_mask_all;
@ -449,9 +450,10 @@ static inline uint32_t update_requested(struct stream *impl)
buffer = &impl->buffers[id];
buffer->this.requested = impl->rate_size;
pw_log_trace_fp("%p: update buffer:%u req:%"PRIu64, impl, id, buffer->this.requested);
pw_log_trace_fp("%p: update buffer:%u req:%"PRIu64" %p", impl, id, buffer->this.requested,
impl->rate_match);
return buffer->this.requested > 0 ? 1 : 0;
return impl->have_requested;
}
static inline void call_process(struct stream *impl)
@ -681,9 +683,11 @@ static inline void copy_position(struct stream *impl, int64_t queued)
if (SPA_LIKELY(impl->rate_match != NULL)) {
impl->rate_queued = impl->rate_match->delay;
impl->rate_size = impl->rate_match->size;
impl->have_requested = impl->rate_size != 0;
} else {
impl->rate_queued = 0;
impl->rate_size = impl->quantum;
impl->have_requested = 1;
}
SPA_SEQ_WRITE(impl->seq);
}