mirror of
				https://gitlab.freedesktop.org/pipewire/pipewire.git
				synced 2025-10-29 05:40:27 -04:00 
			
		
		
		
	audioconvert: disable upmix by default again
But instead ship config override files to enable it again. The idea is that distros can make extra packages that can than be installed to enable the upmixing. Also ship a config file to enable more samplerates. Fixes #3081
This commit is contained in:
		
							parent
							
								
									2d6669d571
								
							
						
					
					
						commit
						d07e1b5641
					
				
					 11 changed files with 96 additions and 4 deletions
				
			
		|  | @ -2870,11 +2870,11 @@ impl_init(const struct spa_handle_factory *factory, | |||
| 	props_reset(&this->props); | ||||
| 
 | ||||
| 	this->mix.options = CHANNELMIX_OPTION_UPMIX | CHANNELMIX_OPTION_MIX_LFE; | ||||
| 	this->mix.upmix = CHANNELMIX_UPMIX_PSD; | ||||
| 	this->mix.upmix = CHANNELMIX_UPMIX_NONE; | ||||
| 	this->mix.log = this->log; | ||||
| 	this->mix.lfe_cutoff = 150.0f; | ||||
| 	this->mix.fc_cutoff = 12000.0f; | ||||
| 	this->mix.rear_delay = 12.0f; | ||||
| 	this->mix.lfe_cutoff = 0.0f; | ||||
| 	this->mix.fc_cutoff = 0.0f; | ||||
| 	this->mix.rear_delay = 0.0f; | ||||
| 	this->mix.widen = 0.0f; | ||||
| 
 | ||||
| 	for (i = 0; info && i < info->n_items; i++) { | ||||
|  |  | |||
							
								
								
									
										8
									
								
								src/daemon/client-rt.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										8
									
								
								src/daemon/client-rt.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,8 @@ | |||
| # Enables upmixing | ||||
| stream.properties = { | ||||
|     channelmix.upmix      = true | ||||
|     channelmix.upmix-method = psd  # none, simple | ||||
|     channelmix.lfe-cutoff = 150 | ||||
|     channelmix.fc-cutoff  = 12000 | ||||
|     channelmix.rear-delay = 12.0 | ||||
| } | ||||
							
								
								
									
										11
									
								
								src/daemon/client-rt.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										11
									
								
								src/daemon/client-rt.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,11 @@ | |||
| conf_files = [ | ||||
|  '20-upmix.conf', | ||||
| ] | ||||
| 
 | ||||
| foreach c : conf_files | ||||
|   configure_file(input : '@0@.in'.format(c), | ||||
|                  output : c, | ||||
|                  configuration : conf_config, | ||||
|                  install_dir : pipewire_confdatadir / 'client-rt.conf.d') | ||||
| endforeach | ||||
| 
 | ||||
							
								
								
									
										8
									
								
								src/daemon/client.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										8
									
								
								src/daemon/client.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,8 @@ | |||
| # Enables upmixing | ||||
| stream.properties = { | ||||
|     channelmix.upmix      = true | ||||
|     channelmix.upmix-method = psd  # none, simple | ||||
|     channelmix.lfe-cutoff = 150 | ||||
|     channelmix.fc-cutoff  = 12000 | ||||
|     channelmix.rear-delay = 12.0 | ||||
| } | ||||
							
								
								
									
										11
									
								
								src/daemon/client.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										11
									
								
								src/daemon/client.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,11 @@ | |||
| conf_files = [ | ||||
|  '20-upmix.conf', | ||||
| ] | ||||
| 
 | ||||
| foreach c : conf_files | ||||
|   configure_file(input : '@0@.in'.format(c), | ||||
|                  output : c, | ||||
|                  configuration : conf_config, | ||||
|                  install_dir : pipewire_confdatadir / 'client.conf.d') | ||||
| endforeach | ||||
| 
 | ||||
|  | @ -86,6 +86,17 @@ configure_file(input : 'pipewire.conf.in', | |||
|                output : 'pipewire-uninstalled.conf', | ||||
|                configuration : conf_config_uninstalled) | ||||
| 
 | ||||
| conf_d_files = [ | ||||
|   'pipewire.conf.d', | ||||
|   'client.conf.d', | ||||
|   'client-rt.conf.d', | ||||
|   'pipewire-pulse.conf.d', | ||||
| ] | ||||
| 
 | ||||
| foreach c : conf_d_files | ||||
|   subdir(c) | ||||
| endforeach | ||||
| 
 | ||||
| pipewire_exec = executable('pipewire', | ||||
|   pipewire_daemon_sources, | ||||
|   install: true, | ||||
|  |  | |||
							
								
								
									
										8
									
								
								src/daemon/pipewire-pulse.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										8
									
								
								src/daemon/pipewire-pulse.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,8 @@ | |||
| # Enables upmixing | ||||
| stream.properties = { | ||||
|     channelmix.upmix      = true | ||||
|     channelmix.upmix-method = psd  # none, simple | ||||
|     channelmix.lfe-cutoff = 150 | ||||
|     channelmix.fc-cutoff  = 12000 | ||||
|     channelmix.rear-delay = 12.0 | ||||
| } | ||||
							
								
								
									
										11
									
								
								src/daemon/pipewire-pulse.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										11
									
								
								src/daemon/pipewire-pulse.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,11 @@ | |||
| conf_files = [ | ||||
|  '20-upmix.conf', | ||||
| ] | ||||
| 
 | ||||
| foreach c : conf_files | ||||
|   configure_file(input : '@0@.in'.format(c), | ||||
|                  output : c, | ||||
|                  configuration : conf_config, | ||||
|                  install_dir : pipewire_confdatadir / 'pipewire-pulse.conf.d') | ||||
| endforeach | ||||
| 
 | ||||
							
								
								
									
										4
									
								
								src/daemon/pipewire.conf.d/10-rates.conf.in
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										4
									
								
								src/daemon/pipewire.conf.d/10-rates.conf.in
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,4 @@ | |||
| # Adds more common rates | ||||
| context.properties = { | ||||
|     default.clock.allowed-rates = [ 44100 48000 88200 96000 ] | ||||
| } | ||||
							
								
								
									
										8
									
								
								src/daemon/pipewire.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										8
									
								
								src/daemon/pipewire.conf.d/20-upmix.conf.in
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,8 @@ | |||
| # Enables upmixing | ||||
| stream.properties = { | ||||
|     channelmix.upmix      = true | ||||
|     channelmix.upmix-method = psd  # none, simple | ||||
|     channelmix.lfe-cutoff = 150 | ||||
|     channelmix.fc-cutoff  = 12000 | ||||
|     channelmix.rear-delay = 12.0 | ||||
| } | ||||
							
								
								
									
										12
									
								
								src/daemon/pipewire.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							
							
						
						
									
										12
									
								
								src/daemon/pipewire.conf.d/meson.build
									
										
									
									
									
										Normal file
									
								
							|  | @ -0,0 +1,12 @@ | |||
| conf_files = [ | ||||
|  '10-rates.conf', | ||||
|  '20-upmix.conf', | ||||
| ] | ||||
| 
 | ||||
| foreach c : conf_files | ||||
|   configure_file(input : '@0@.in'.format(c), | ||||
|                  output : c, | ||||
|                  configuration : conf_config, | ||||
|                  install_dir : pipewire_confdatadir / 'pipewire.conf.d') | ||||
| endforeach | ||||
| 
 | ||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Wim Taymans
						Wim Taymans