From ce687d6518c8408bd73e2c9254c64cb91de13eba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Sat, 6 Nov 2021 15:25:06 +0100 Subject: [PATCH] pulse-server: module-zeroconf-publish: do not query twice Whether the object is a sink or source is already queried at the beginning of the function, and is kept in local variables. Use those instead of calling `pw_manager_object_is_{sink,source}()` again. --- .../module-protocol-pulse/modules/module-zeroconf-publish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c b/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c index b40c4042a..b5308a96a 100644 --- a/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c +++ b/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c @@ -274,9 +274,9 @@ static void get_service_data(struct module_zeroconf_publish_data *d, collect_device_info(o, card, &dev_info, false, &impl->defs); if ((str = spa_dict_lookup(info->props, PW_KEY_DEVICE_API)) != NULL) { - if (pw_manager_object_is_sink(o)) + if (is_sink) flags |= SINK_HARDWARE; - else if (pw_manager_object_is_source(o)) + else if (is_source) flags |= SOURCE_HARDWARE; }