mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

treewide: fix some strict-prototypes Clang warnings/errors

Browse source 
Clang 15 at least with my build configuration emits warnings about
function prototypes that lack argument types. Most notably this
happens with functions that take no arguments which in compiler view
equates to the void type i.e. void f(void) instead of void f(). As I
understand, this will become an error in some future Clang release,
so might as well fix it now.

Since these were discovered not by a linter but by the actual compiler
for my particular build configuration, some f() may have escaped for
now. But at least it's enough to build PipeWire with most optional
features enabled even when -Werror=strict-prototypes is enabled.

For anyone else wanting to have a go at this, these can be upgraded
from warnings to errors by adding -Werror=strict-prototypes to the
custom CFLAGS which probably works with GCC, too, but has only been
done with Clang 15.0.2.

Finally my editor automatically stripped trailing spaces upon saving
the modified files. I assume it's probably not worth keeping those
invisible bytes around but this may have slightly dubious implications
as it did also turn indented empty lines of JACK license header into
regular empty lines.

Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
This commit is contained in:
Niklāvs Koļesņikovs 2022-10-10 17:49:57 +03:00 • committed by Wim Taymans
parent 7066aa7e15
commit cba334f028
11 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/modules/module-filter-chain/pffft.c
View file

@ -25,7 +25,7 @@
Laboratory, the University Corporation for Atmospheric Research,
nor the names of its sponsors or contributors may be used to
endorse or promote products derived from this Software without
specific prior written permission.
specific prior written permission.
- Redistributions of source code must retain the above copyright
notices, this list of conditions, and the disclaimer below.
@ -52,7 +52,7 @@
*/
/*
ChangeLog:
ChangeLog:
- 2011/10/02, version 1: This is the very first release of this file.
*/
@ -243,7 +243,7 @@ typedef union v4sf_union {
#define assertv4(v,f0,f1,f2,f3) assert(v.f[0] == (f0) && v.f[1] == (f1) && v.f[2] == (f2) && v.f[3] == (f3))
/* detect bugs with the vector support macros */
static void validate_pffft_simd()
static void validate_pffft_simd(void)
{
float f[16] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 };
v4sf_union a0, a1, a2, a3, t, u;
@ -301,7 +301,7 @@ static void validate_pffft_simd()
assertv4(a3, 3, 7, 11, 15);
}
#else
static void validate_pffft_simd()
static void validate_pffft_simd(void)
{
} // allow test_pffft.c to call this function even when simd is not available..
#endif //!PFFFT_SIMD_DISABLE
@ -1421,7 +1421,7 @@ static PFFFT_Setup *new_setup_simd(int N, pffft_transform_t transform)
{
PFFFT_Setup *s = (PFFFT_Setup *) malloc(sizeof(PFFFT_Setup));
int k, m;
/* unfortunately, the fft size must be a multiple of 16 for complex FFTs
/* unfortunately, the fft size must be a multiple of 16 for complex FFTs
and 32 for real FFTs -- a lot of stuff would need to be rewritten to
handle other cases (or maybe just switch to a scalar fft, I don't know..) */
if (transform == PFFFT_REAL) {
@ -1615,7 +1615,7 @@ static void pffft_cplx_finalize(int Ncvec, const v4sf * in, v4sf * out, const v4
[0 0 0 0 1 1 1 1] * [i0]
[0 1 0 -1 1 0 -1 0] [i1]
[0 0 0 0 1 -1 1 -1] [i2]
[0 -1 0 1 1 0 -1 0] [i3]
[0 -1 0 1 1 0 -1 0] [i3]
*/
r0 = VADD(sr0, sr1);
@ -1719,7 +1719,7 @@ static ALWAYS_INLINE(void) pffft_real_finalize_4x4(const v4sf * in0,
[0 0 0 0 1 1 1 1] * [i0]
[0 -1 0 1 -1 0 1 0] [i1]
[0 -1 0 1 1 0 -1 0] [i2]
[0 0 0 0 -1 1 -1 1] [i3]
[0 0 0 0 -1 1 -1 1] [i3]
*/
//cerr << "matrix initial, before e , REAL:\n 1: " << r0 << "\n 1: " << r1 << "\n 1: " << r2 << "\n 1: " << r3 << "\n";
@ -1832,7 +1832,7 @@ static ALWAYS_INLINE(void) pffft_real_preprocess_4x4(const v4sf * in,
[0 0 0 0 1 -1 1 -1] * [i0]
[0 -1 1 0 1 0 0 1] [i1]
[0 0 0 0 1 1 -1 -1] [i2]
[0 1 -1 0 1 0 0 1] [i3]
[0 1 -1 0 1 0 0 1] [i3]
*/
v4sf sr0 = VADD(r0, r3), dr0 = VSUB(r0, r3);

4
src/modules/module-filter-chain/pffft.h
View file

@ -165,13 +165,13 @@ extern "C" {
/*
the float buffers must have the correct alignment (16-byte boundary
on intel and powerpc). This function may be used to obtain such
correctly aligned buffers.
correctly aligned buffers.
*/
void *pffft_aligned_malloc(size_t nb_bytes);
void pffft_aligned_free(void *);
/* return 4 or 1 depending on whether support for SSE/Altivec instructions was enabled when building pffft.c */
int pffft_simd_size();
int pffft_simd_size(void);
void pffft_select_cpu(int flags);