mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-01 22:58:50 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

treewide: fix some strict-prototypes Clang warnings/errors

Browse source 
Clang 15 at least with my build configuration emits warnings about
function prototypes that lack argument types. Most notably this
happens with functions that take no arguments which in compiler view
equates to the void type i.e. void f(void) instead of void f(). As I
understand, this will become an error in some future Clang release,
so might as well fix it now.

Since these were discovered not by a linter but by the actual compiler
for my particular build configuration, some f() may have escaped for
now. But at least it's enough to build PipeWire with most optional
features enabled even when -Werror=strict-prototypes is enabled.

For anyone else wanting to have a go at this, these can be upgraded
from warnings to errors by adding -Werror=strict-prototypes to the
custom CFLAGS which probably works with GCC, too, but has only been
done with Clang 15.0.2.

Finally my editor automatically stripped trailing spaces upon saving
the modified files. I assume it's probably not worth keeping those
invisible bytes around but this may have slightly dubious implications
as it did also turn indented empty lines of JACK license header into
regular empty lines.

Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
This commit is contained in:
Niklāvs Koļesņikovs 2022-10-10 17:49:57 +03:00 • committed by Wim Taymans
parent 7066aa7e15
commit cba334f028
11 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spa/tests/benchmark-pod.c
View file

@ -37,7 +37,7 @@
#define MAX_COUNT 10000000
static void test_builder()
static void test_builder(void)
{
uint8_t buffer[1024];
struct spa_pod_builder b = { NULL, };
@ -90,7 +90,7 @@ static void test_builder()
t2 - t1, count, count * (uint64_t)SPA_NSEC_PER_SEC / (t2 - t1));
}
static void test_builder2()
static void test_builder2(void)
{
uint8_t buffer[1024];
struct spa_pod_builder b = { NULL, };
@ -131,7 +131,7 @@ static void test_builder2()
t2 - t1, count, count * (uint64_t)SPA_NSEC_PER_SEC / (t2 - t1));
}
static void test_parse()
static void test_parse(void)
{
uint8_t buffer[1024];
struct spa_pod_builder b = { NULL, };
@ -216,7 +216,7 @@ static void test_parse()
t2 - t1, count, count * (uint64_t)SPA_NSEC_PER_SEC / (t2 - t1));
}
static void test_parser()
static void test_parser(void)
{
uint8_t buffer[1024];
struct spa_pod_builder b = { NULL, };