mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

treewide: fix some strict-prototypes Clang warnings/errors

Browse source 
Clang 15 at least with my build configuration emits warnings about
function prototypes that lack argument types. Most notably this
happens with functions that take no arguments which in compiler view
equates to the void type i.e. void f(void) instead of void f(). As I
understand, this will become an error in some future Clang release,
so might as well fix it now.

Since these were discovered not by a linter but by the actual compiler
for my particular build configuration, some f() may have escaped for
now. But at least it's enough to build PipeWire with most optional
features enabled even when -Werror=strict-prototypes is enabled.

For anyone else wanting to have a go at this, these can be upgraded
from warnings to errors by adding -Werror=strict-prototypes to the
custom CFLAGS which probably works with GCC, too, but has only been
done with Clang 15.0.2.

Finally my editor automatically stripped trailing spaces upon saving
the modified files. I assume it's probably not worth keeping those
invisible bytes around but this may have slightly dubious implications
as it did also turn indented empty lines of JACK license header into
regular empty lines.

Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
This commit is contained in:
Niklāvs Koļesņikovs 2022-10-10 17:49:57 +03:00 • committed by Wim Taymans
parent 7066aa7e15
commit cba334f028
11 changed files with 28 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

10
pipewire-jack/jack/uuid.h
View file

@ -1,18 +1,18 @@
/*
Copyright (C) 2013 Paul Davis
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published by
the Free Software Foundation; either version 2.1 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public License
along with this program; if not, write to the Free Software
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
*/
@ -30,7 +30,7 @@ extern "C" {
#define JACK_UUID_STRING_SIZE (JACK_UUID_SIZE+1) /* includes trailing null */
#define JACK_UUID_EMPTY_INITIALIZER 0
extern jack_uuid_t jack_client_uuid_generate ();
extern jack_uuid_t jack_client_uuid_generate (void);
extern jack_uuid_t jack_port_uuid_generate (uint32_t port_id);
extern uint32_t jack_uuid_to_index (jack_uuid_t);

2
pipewire-jack/src/pipewire-jack.c
View file

@ -5715,7 +5715,7 @@ jack_nframes_t jack_time_to_frames(const jack_client_t *client, jack_time_t usec
}
SPA_EXPORT
jack_time_t jack_get_time()
jack_time_t jack_get_time(void)
{
struct timespec ts;
clock_gettime(CLOCK_MONOTONIC, &ts);

2
pipewire-jack/src/uuid.c
View file

@ -33,7 +33,7 @@
#include <pipewire/pipewire.h>
SPA_EXPORT
jack_uuid_t jack_client_uuid_generate ()
jack_uuid_t jack_client_uuid_generate (void)
{
static uint32_t uuid_cnt = 0;
jack_uuid_t uuid = 0x2; /* JackUUIDClient */;